From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11047 invoked from network); 30 May 2007 09:49:48 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.0 (2007-05-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=no version=3.2.0 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 30 May 2007 09:49:48 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 70393 invoked from network); 30 May 2007 09:49:42 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 30 May 2007 09:49:42 -0000 Received: (qmail 2413 invoked by alias); 30 May 2007 09:49:40 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 23494 Received: (qmail 2400 invoked from network); 30 May 2007 09:49:39 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 30 May 2007 09:49:39 -0000 Received: (qmail 70107 invoked from network); 30 May 2007 09:49:39 -0000 Received: from cluster-c.mailcontrol.com (168.143.177.190) by a.mx.sunsite.dk with SMTP; 30 May 2007 09:49:34 -0000 Received: from cameurexb01.EUROPE.ROOT.PRI ([62.189.241.200]) by rly23c.srv.mailcontrol.com (MailControl) with ESMTP id l4U9l1xE030763 for ; Wed, 30 May 2007 10:49:29 +0100 Received: from news01.csr.com ([10.103.143.38]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.1830); Wed, 30 May 2007 10:49:15 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.13.8/8.13.4) with ESMTP id l4U9nFpQ009645 for ; Wed, 30 May 2007 10:49:15 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.13.8/8.13.8/Submit) with ESMTP id l4U9nFw4009642 for ; Wed, 30 May 2007 10:49:15 +0100 Message-Id: <200705300949.l4U9nFw4009642@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk (Zsh hackers list) Subject: Re: PATCH: test output to terminal dehackery In-reply-to: <070529202902.ZM13215@torch.brasslantern.com> References: <200705291443.l4TEhemW027211@news01.csr.com> <070529202902.ZM13215@torch.brasslantern.com> Comments: In-reply-to Bart Schaefer message dated "Tue, 29 May 2007 20:29:02 -0700." Date: Wed, 30 May 2007 10:49:15 +0100 From: Peter Stephenson X-OriginalArrivalTime: 30 May 2007 09:49:15.0478 (UTC) FILETIME=[C8BE8F60:01C7A29F] Content-Type: text/plain MIME-Version: 1.0 X-Scanned-By: MailControl A-07-07-05 (www.mailcontrol.com) on 10.67.0.133 Bart Schaefer wrote: > On May 29, 3:43pm, Peter Stephenson wrote: > } > } We now have the technology to open a file descriptor for test input and > } terminal output without using up one of the standard shell ones. > } The {fd} syntax opens up an unused fd from 10 on. > > Hrm. I'm ambivalent about this patch. The {fd}< syntax is one of the > things that gets tested for correctness quite a bit later on. If it > doesn't work properly here, could the whole test suite fail? > > That is, I'm wondering if the implementation of the test suite should > restrict itself to the most basic shell operations possible and only > the tests themselves employ extended functionality. I don't really believe in the division between basic and extended functionality, except as regards add-ons; if the shell's broken it needs fixing. You're correct that the new syntax isn't used as much so it's more likely it would get broken without anyone noticing. I don't see any implication beyond needing to fix that before running other tests, however; that can in principle happen with anything. -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070 To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview