From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22722 invoked from network); 27 Sep 2007 11:32:37 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 27 Sep 2007 11:32:37 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 78993 invoked from network); 27 Sep 2007 11:32:31 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 27 Sep 2007 11:32:31 -0000 Received: (qmail 815 invoked by alias); 27 Sep 2007 11:32:28 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 23841 Received: (qmail 801 invoked from network); 27 Sep 2007 11:32:28 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 27 Sep 2007 11:32:28 -0000 Received: (qmail 78718 invoked from network); 27 Sep 2007 11:32:28 -0000 Received: from acolyte.scowler.net (216.254.112.45) by a.mx.sunsite.dk with SMTP; 27 Sep 2007 11:32:22 -0000 Received: by acolyte.scowler.net (Postfix, from userid 1000) id BD6375C2AF; Thu, 27 Sep 2007 07:32:19 -0400 (EDT) Date: Thu, 27 Sep 2007 07:32:19 -0400 From: Clint Adams To: Mikael Magnusson Cc: zsh-workers@sunsite.dk Subject: Re: PATCH: _git (large) Message-ID: <20070927113219.GA15735@scowler.net> Mail-Followup-To: Mikael Magnusson , zsh-workers@sunsite.dk References: <20070925155927.GA22272@scowler.net> <237967ef0709251034u4f1edc29i4ecadbed57bee1d4@mail.gmail.com> <20070925175434.GA25244@scowler.net> <237967ef0709251144t4b553b5dla9ff570de41bbed4@mail.gmail.com> <20070925190011.GA26894@scowler.net> <237967ef0709261616q39d1f76al9e34b8b5fb6603a7@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <237967ef0709261616q39d1f76al9e34b8b5fb6603a7@mail.gmail.com> User-Agent: Mutt/1.5.16 (2007-06-11) On Thu, Sep 27, 2007 at 01:16:00AM +0200, Mikael Magnusson wrote: > Found another issue, with fix > There is a reference to __git_tag_ids on line 2677 but i'm not sure > what it's supposed to do exactly. > > (( $+functions[__git_tag_ids] )) || > __git_tag_ids () { > } > > It should possibly just be removed? I think this is a better fix, don't you? Index: Completion/Unix/Command/_git =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v retrieving revision 1.26 diff -u -r1.26 _git --- Completion/Unix/Command/_git 25 Sep 2007 18:58:16 -0000 1.26 +++ Completion/Unix/Command/_git 27 Sep 2007 11:29:36 -0000 @@ -2676,6 +2676,12 @@ (( $+functions[__git_tag_ids] )) || __git_tag_ids () { + local -a refs + + refs=(${${(f)"$(_call_program tag_ids git ls-remote --tags ./. 2>/dev/null)"}%$'\t'*}) + __git_command_successful || return + + _wanted tag_id expl 'tag object hash' compadd - $refs } (( $+functions[__git_heads_or_tags] )) ||