From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16151 invoked from network); 29 Sep 2007 21:19:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 29 Sep 2007 21:19:50 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 85618 invoked from network); 29 Sep 2007 21:19:44 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 29 Sep 2007 21:19:44 -0000 Received: (qmail 16233 invoked by alias); 29 Sep 2007 21:19:42 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 23854 Received: (qmail 16218 invoked from network); 29 Sep 2007 21:19:41 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 29 Sep 2007 21:19:41 -0000 Received: (qmail 85285 invoked from network); 29 Sep 2007 21:19:41 -0000 Received: from acolyte.scowler.net (216.254.112.45) by a.mx.sunsite.dk with SMTP; 29 Sep 2007 21:19:35 -0000 Received: by acolyte.scowler.net (Postfix, from userid 1000) id 72E9E5C2AF; Sat, 29 Sep 2007 17:19:32 -0400 (EDT) Date: Sat, 29 Sep 2007 17:19:32 -0400 From: Clint Adams To: zsh-workers@sunsite.dk, jblache@debian.org Subject: Re: PATCH: _dpatch-edit-patch Message-ID: <20070929211932.GA10219@scowler.net> Mail-Followup-To: zsh-workers@sunsite.dk, jblache@debian.org References: <20070929104314.GA7801@scowler.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070929104314.GA7801@scowler.net> User-Agent: Mutt/1.5.16 (2007-06-11) On Sat, Sep 29, 2007 at 06:43:14AM -0400, Clint Adams wrote: > dpatch-edit-patch completion by Julien BLACHE. This 1) lowercases some capitals 2) completes a colon-separated path list for -P 3) fails to actually complete shells after -l ; is there call for a generic utility function that parses /etc/shells or $(getent passwd) or something to get a list of shells? Julien, does dpatch-edit-patch break with the .dpatch suffix on the command-line or does it work whether or not it's there? Index: Completion/Debian/Command/_dpatch-edit-patch =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Debian/Command/_dpatch-edit-patch,v retrieving revision 1.1 diff -u -r1.1 _dpatch-edit-patch --- Completion/Debian/Command/_dpatch-edit-patch 29 Sep 2007 11:08:47 -0000 1.1 +++ Completion/Debian/Command/_dpatch-edit-patch 29 Sep 2007 21:13:05 -0000 @@ -2,16 +2,16 @@ _arguments \ '(-d --description)'{-d,--description=}'[description for the new patch, if applicable]' \ - '(-o --outdir)'{-o,--outdir=}'[output directory for patches]:Patch output directory:_files -/' \ - '(-s --sourcedir)'{-s,--sourcedir=}'[source directory]:Source directory:_files -/' \ - '(-t --tmpdir)'{-t,--tmpdir=}'[temporary directory]:Temporary directory:_files -/' \ - '(-p --stampdir)'{-p,--stampdir=}'[stamp directory]:Stamp directory:_files -/' \ - '(-e --exclude)'{-e,--exclude}'[list of files and directories to be excluded]:Excluded files and directories:_files' \ - '(-b --debianonly)'{-b,--debianonly=}'[unpack .orig.tar.gz before invoking the shell]:Path to .orig.tar.gz:_files' \ + '(-o --outdir)'{-o,--outdir=}'[output directory for patches]:patch output directory:_files -/' \ + '(-s --sourcedir)'{-s,--sourcedir=}'[source directory]:source directory:_files -/' \ + '(-t --tmpdir)'{-t,--tmpdir=}'[temporary directory]:temporary directory:_files -/' \ + '(-p --stampdir)'{-p,--stampdir=}'[stamp directory]:stamp directory:_files -/' \ + '(-e --exclude)'{-e,--exclude}'[list of files and directories to be excluded]:excluded files and directories:_files' \ + '(-b --debianonly)'{-b,--debianonly=}'[unpack .orig.tar.gz before invoking the shell]:path to .orig.tar.gz:_files' \ '(-k --keeptemp)'{-k,--keeptemp}'[keep working source tree after exit]' \ '(-c --clean)'{-c,--clean}'[clean the current directory]' \ - '(-l --shell)'{-l,--shell=}'[shell to be invoked]' \ - '(-P --origtargzpath)'{-P,--origtargzpath=}'[colon-separated list of paths containing upstream tarballs, use with -b]:Path to upstream tarballs:_files -/' \ - '(-h --help)'{-h,--help}'[Help text]' \ - '1:Patch name:_files -W $PWD/debian/patches -g "*.dpatch"' \ - '2:Base patch name:_files -W $PWD/debian/patches -g "*.dpatch"' + '(-l --shell)'{-l,--shell=}'[shell to be invoked]:shell:' \ + '(-P --origtargzpath)'{-P,--origtargzpath=}'[colon-separated list of paths containing upstream tarballs, use with -b]:path to upstream tarballs:_dir_list' \ + '(-h --help)'{-h,--help}'[help text]' \ + '1:patch name:_files -W $PWD/debian/patches -g "*.dpatch"' \ + '2:base patch name:_files -W $PWD/debian/patches -g "*.dpatch"'