From: Clint Adams <clint@zsh.org>
To: zsh-workers@sunsite.dk
Subject: PATCH: _git space pollution
Date: Sun, 30 Sep 2007 07:12:26 -0400 [thread overview]
Message-ID: <20070930111226.GA17907@scowler.net> (raw)
This parameter is used exactly twice, immediately after its assignment.
I would say that all the globally-declared parameters should be prefixed
with _git to avoid namespace pollution, but really they shouldn't be in
the global space at all.
Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.30
diff -u -r1.30 _git
--- Completion/Unix/Command/_git 29 Sep 2007 06:06:15 -0000 1.30
+++ Completion/Unix/Command/_git 30 Sep 2007 11:08:17 -0000
@@ -107,7 +107,7 @@
'(--no-tags -t --tags)'{-t,--tags}'[fetch remote tags]'
)
-
+local author_conversion_file_arg_spec
author_conversion_file_arg_spec='[specify author-conversion file]:author-conversion file:_files'
declare -g author_conversion_file_arg=
next reply other threads:[~2007-09-30 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-30 11:12 Clint Adams [this message]
2007-09-30 11:27 ` Clint Adams
2007-10-01 7:29 ` Nikolai Weibull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070930111226.GA17907@scowler.net \
--to=clint@zsh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).