From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22357 invoked from network); 30 Sep 2007 11:12:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 30 Sep 2007 11:12:50 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 77759 invoked from network); 30 Sep 2007 11:12:41 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 30 Sep 2007 11:12:41 -0000 Received: (qmail 5866 invoked by alias); 30 Sep 2007 11:12:34 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 23862 Received: (qmail 5848 invoked from network); 30 Sep 2007 11:12:33 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 30 Sep 2007 11:12:33 -0000 Received: (qmail 76538 invoked from network); 30 Sep 2007 11:12:33 -0000 Received: from acolyte.scowler.net (216.254.112.45) by a.mx.sunsite.dk with SMTP; 30 Sep 2007 11:12:28 -0000 Received: by acolyte.scowler.net (Postfix, from userid 1000) id 6F8D65C364; Sun, 30 Sep 2007 07:12:26 -0400 (EDT) Date: Sun, 30 Sep 2007 07:12:26 -0400 From: Clint Adams To: zsh-workers@sunsite.dk Subject: PATCH: _git space pollution Message-ID: <20070930111226.GA17907@scowler.net> Mail-Followup-To: zsh-workers@sunsite.dk MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.16 (2007-06-11) This parameter is used exactly twice, immediately after its assignment. I would say that all the globally-declared parameters should be prefixed with _git to avoid namespace pollution, but really they shouldn't be in the global space at all. Index: Completion/Unix/Command/_git =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v retrieving revision 1.30 diff -u -r1.30 _git --- Completion/Unix/Command/_git 29 Sep 2007 06:06:15 -0000 1.30 +++ Completion/Unix/Command/_git 30 Sep 2007 11:08:17 -0000 @@ -107,7 +107,7 @@ '(--no-tags -t --tags)'{-t,--tags}'[fetch remote tags]' ) - +local author_conversion_file_arg_spec author_conversion_file_arg_spec='[specify author-conversion file]:author-conversion file:_files' declare -g author_conversion_file_arg=