From: Clint Adams <clint@zsh.org>
To: Nikolai Weibull <now@bitwi.se>
Cc: Mikael Magnusson <mikachu@gmail.com>,
zsh-workers <zsh-workers@sunsite.dk>
Subject: Re: Make git-commit complete both modified files and git-added files.
Date: Thu, 4 Oct 2007 04:27:36 -0400 [thread overview]
Message-ID: <20071004082736.GA17606@scowler.net> (raw)
In-Reply-To: <dbfc82860710040105o8d07bd3h784fa550f3b571ab@mail.gmail.com>
On Thu, Oct 04, 2007 at 10:05:49AM +0200, Nikolai Weibull wrote:
> What do you need gitdir for?
He doesn't.
"files" is a pretty generic name for a tag.
Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.40
diff -u -r1.40 _git
--- Completion/Unix/Command/_git 4 Oct 2007 08:24:33 -0000 1.40
+++ Completion/Unix/Command/_git 4 Oct 2007 08:25:55 -0000
@@ -2627,8 +2627,7 @@
#this is for git-commit which can take files both git-added and not
(( $+functions[__git_changed_files] )) ||
__git_changed_files () {
- gitdir=$(_call_program gitdir git rev-parse --git-dir 2>/dev/null)
- __git_command_successful || return
+ local -a files
files=(${(ps:\0:)"$(_call_program files git diff-index -z --name-only HEAD 2>/dev/null)"})
__git_command_successful || return
prev parent reply other threads:[~2007-10-04 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 1:05 Mikael Magnusson
2007-10-04 8:05 ` Nikolai Weibull
2007-10-04 8:27 ` Clint Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071004082736.GA17606@scowler.net \
--to=clint@zsh.org \
--cc=mikachu@gmail.com \
--cc=now@bitwi.se \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).