From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-23908-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 22032 invoked from network); 6 Oct 2007 00:55:20 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.3
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns1.primenet.com.au with SMTP; 6 Oct 2007 00:55:20 -0000
Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts)
Received: (qmail 96940 invoked from network); 6 Oct 2007 00:55:14 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 6 Oct 2007 00:55:14 -0000
Received: (qmail 1862 invoked by alias); 6 Oct 2007 00:55:12 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 23908
Received: (qmail 1849 invoked from network); 6 Oct 2007 00:55:11 -0000
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by sunsite.dk with SMTP; 6 Oct 2007 00:55:11 -0000
Received: (qmail 96673 invoked from network); 6 Oct 2007 00:55:11 -0000
Received: from acolyte.scowler.net (216.254.112.45)
  by a.mx.sunsite.dk with SMTP; 6 Oct 2007 00:55:06 -0000
Received: by acolyte.scowler.net (Postfix, from userid 1000)
	id B75BF5C2B0; Fri,  5 Oct 2007 20:55:03 -0400 (EDT)
Date: Fri, 5 Oct 2007 20:55:03 -0400
From: Clint Adams <clint@zsh.org>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh-workers <zsh-workers@sunsite.dk>
Subject: Re: git-svn completion doesn't work
Message-ID: <20071006005503.GA21782@scowler.net>
Mail-Followup-To: Mikael Magnusson <mikachu@gmail.com>,
	zsh-workers <zsh-workers@sunsite.dk>
References: <237967ef0710050726v227ed8e3q3a92e68324c19bec@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <237967ef0710050726v227ed8e3q3a92e68324c19bec@mail.gmail.com>
User-Agent: Mutt/1.5.16 (2007-06-11)

On Fri, Oct 05, 2007 at 04:26:05PM +0200, Mikael Magnusson wrote:
> @@ -2472,7 +2472,7 @@ _git-svn () {
>          '(-h -H --help)'{-h,-H,--help}'[display usage information]' \
>          '(-V --version)'{-V,--version}'[display version information]' \
>          '--minimize-connections[undocumented]' \
> -        '(-R --svn-remote --remote)'{-R,--svn-remote,--remote}'[svn
> remote to use]:svn remote:__git_svn-remotes'
> +        '(-R --svn-remote --remote)'{-R,--svn-remote,--remote}'[svn
> remote to use]:svn remote:__git_svn-remotes' \
>          '(-i --id)'{-i,--id}'[set GIT_SVN_ID]:GIT_SVN_ID'
>          $arguments && ret=0

Committed.

> however, then it moved on to saying
> _git-svn:155: command not found: --username=[username to use for SVN
> transport]:username:_users

Try this.

Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.42
diff -u -r1.42 _git
--- Completion/Unix/Command/_git	6 Oct 2007 00:48:15 -0000	1.42
+++ Completion/Unix/Command/_git	6 Oct 2007 00:54:33 -0000
@@ -2473,7 +2473,7 @@
         '(-V --version)'{-V,--version}'[display version information]' \
         '--minimize-connections[undocumented]' \
         '(-R --svn-remote --remote)'{-R,--svn-remote,--remote}'[svn remote to use]:svn remote:__git_svn-remotes' \
-        '(-i --id)'{-i,--id}'[set GIT_SVN_ID]:GIT_SVN_ID'
+        '(-i --id)'{-i,--id}'[set GIT_SVN_ID]:GIT_SVN_ID' \
         $arguments && ret=0
 
       case $state in

> and I have no idea why it does that. I also believe this change should
> be done but not sure:

I don't think so.