From: Clint Adams <clint@zsh.org>
To: zsh-workers@sunsite.dk
Subject: Re: uuid module out-of-tree
Date: Thu, 11 Oct 2007 11:08:11 -0400 [thread overview]
Message-ID: <20071011150811.GA3525@scowler.net> (raw)
In-Reply-To: <20071011144428.GA2134@scowler.net>
On Thu, Oct 11, 2007 at 10:44:28AM -0400, Clint Adams wrote:
> One thing to do would be to ship some kind of include file for autoconf
> so that the out-of-tree module can set all the necessary defines
> (such as HAVE_STDARG_H or HAVE_VARARGS_H) needed by system.h
>
> Alternately, the portions of system.h that require config.h but don't
> need to be exported for out-of-tree modules could be split out to
> a different header or guarded with #ifdefs.
With the following aczshoot.m4 function (included from acinclude.m4)
AC_DEFUN(zsh_OOT,
[
AC_CHECK_HEADERS(stdarg.h varargs.h termios.h termio.h)
AC_TYPE_SIGNAL
AC_DEFINE([ZSH_OOT_MODULE], [], [Out-of-tree module])
])
and the following patch, the complete config.h is unnecessary. The uuid
module doesn't need stdarg.h, varargs.h, termios.h, termio.h, or
RETSIGTYPE, however. Any thoughts?
diff --git a/Src/system.h b/Src/system.h
index 781a907..022ace2 100644
--- a/Src/system.h
+++ b/Src/system.h
@@ -225,7 +225,7 @@ char *alloca _((size_t));
#endif
/* This is needed by some old SCO unices */
-#ifndef HAVE_STRUCT_TIMEZONE
+#if !defined(HAVE_STRUCT_TIMEZONE) && !defined(ZSH_OOT_MODULE)
struct timezone {
int tz_minuteswest;
int tz_dsttime;
next prev parent reply other threads:[~2007-10-11 15:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 14:44 Clint Adams
2007-10-11 15:08 ` Clint Adams [this message]
2007-10-11 19:23 ` Peter Stephenson
2007-10-11 20:28 ` Clint Adams
2007-10-12 8:50 ` Peter Stephenson
2007-10-12 12:43 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011150811.GA3525@scowler.net \
--to=clint@zsh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).