From: Clint Adams <clint@zsh.org>
To: Peter Stephenson <pws@csr.com>
Cc: zsh-workers@sunsite.dk
Subject: Re: PATCH: make curses module not need wideness
Date: Mon, 15 Oct 2007 09:35:08 -0400 [thread overview]
Message-ID: <20071015133508.GB2882@scowler.net> (raw)
In-Reply-To: <200710150911.l9F9BqR1003986@news01.csr.com>
On Mon, Oct 15, 2007 at 10:11:52AM +0100, Peter Stephenson wrote:
> I'm also wondering if it wouldn't be better for the window number/name
> to be the first regular argument in all cases.
First:
Index: Doc/Zsh/mod_curses.yo
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Zsh/mod_curses.yo,v
retrieving revision 1.2
diff -u -r1.2 mod_curses.yo
--- Doc/Zsh/mod_curses.yo 15 Oct 2007 13:30:08 -0000 1.2
+++ Doc/Zsh/mod_curses.yo 15 Oct 2007 13:33:53 -0000
@@ -6,7 +6,7 @@
startitem()
findex(zcurses)
cindex(windows, curses)
-xitem(tt(zcurses) tt(-a) var(nlines) var(ncols) var(begin_y) var(begin_x) var(targetwin) )
+xitem(tt(zcurses) tt(-a) var(targetwin) var(nlines) var(ncols) var(begin_y) var(begin_x) )
xitem(tt(zcurses) tt(-d) var(targetwin) )
xitem(tt(zcurses) tt(-r) var(targetwin) )
xitem(tt(zcurses) tt(-m) var(targetwin) var(new_y) var(new_x) )
Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.5
diff -u -r1.5 curses.c
--- Src/Modules/curses.c 15 Oct 2007 13:30:10 -0000 1.5
+++ Src/Modules/curses.c 15 Oct 2007 13:33:53 -0000
@@ -105,14 +105,14 @@
if (OPT_ISSET(ops,'a')) {
int nlines, ncols, begin_y, begin_x;
- nlines = atoi(args[0]);
- ncols = atoi(args[1]);
- begin_y = atoi(args[2]);
- begin_x = atoi(args[3]);
- targetwin = zcurses_validate_window(args[4], ZCURSES_UNUSED);
+ targetwin = zcurses_validate_window(args[0], ZCURSES_UNUSED);
+ nlines = atoi(args[1]);
+ ncols = atoi(args[2]);
+ begin_y = atoi(args[3]);
+ begin_x = atoi(args[4]);
if (targetwin == -1) {
- zerrnam(nam, "%s: %s", zcurses_strerror(zc_errno), args[4], 0);
+ zerrnam(nam, "%s: %s", zcurses_strerror(zc_errno), args[0], 0);
return 1;
}
next prev parent reply other threads:[~2007-10-15 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 4:21 Clint Adams
2007-10-14 16:26 ` Bart Schaefer
2007-10-14 17:08 ` Clint Adams
2007-10-14 22:16 ` Bart Schaefer
2007-10-15 9:11 ` Peter Stephenson
2007-10-15 13:35 ` Clint Adams [this message]
2007-10-15 14:34 ` Clint Adams
2007-10-15 14:58 ` Peter Stephenson
2007-10-15 16:45 ` Clint Adams
2007-10-15 13:25 ` Clint Adams
2007-10-15 15:04 ` Bart Schaefer
2007-10-15 16:48 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015133508.GB2882@scowler.net \
--to=clint@zsh.org \
--cc=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).