From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26129 invoked from network); 15 Oct 2007 13:35:23 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 15 Oct 2007 13:35:23 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 79012 invoked from network); 15 Oct 2007 13:35:17 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 15 Oct 2007 13:35:17 -0000 Received: (qmail 9027 invoked by alias); 15 Oct 2007 13:35:15 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 23958 Received: (qmail 9008 invoked from network); 15 Oct 2007 13:35:14 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 15 Oct 2007 13:35:14 -0000 Received: (qmail 78698 invoked from network); 15 Oct 2007 13:35:14 -0000 Received: from acolyte.scowler.net (216.254.112.45) by a.mx.sunsite.dk with SMTP; 15 Oct 2007 13:35:09 -0000 Received: by acolyte.scowler.net (Postfix, from userid 1000) id 73D9D5C58C; Mon, 15 Oct 2007 09:35:08 -0400 (EDT) Date: Mon, 15 Oct 2007 09:35:08 -0400 From: Clint Adams To: Peter Stephenson Cc: zsh-workers@sunsite.dk Subject: Re: PATCH: make curses module not need wideness Message-ID: <20071015133508.GB2882@scowler.net> Mail-Followup-To: Peter Stephenson , zsh-workers@sunsite.dk References: <20071014042142.GA27713@scowler.net> <071014092646.ZM21802@torch.brasslantern.com> <20071014170856.GA14631@scowler.net> <071014151608.ZM26588@torch.brasslantern.com> <200710150911.l9F9BqR1003986@news01.csr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710150911.l9F9BqR1003986@news01.csr.com> User-Agent: Mutt/1.5.16 (2007-06-11) On Mon, Oct 15, 2007 at 10:11:52AM +0100, Peter Stephenson wrote: > I'm also wondering if it wouldn't be better for the window number/name > to be the first regular argument in all cases. First: Index: Doc/Zsh/mod_curses.yo =================================================================== RCS file: /cvsroot/zsh/zsh/Doc/Zsh/mod_curses.yo,v retrieving revision 1.2 diff -u -r1.2 mod_curses.yo --- Doc/Zsh/mod_curses.yo 15 Oct 2007 13:30:08 -0000 1.2 +++ Doc/Zsh/mod_curses.yo 15 Oct 2007 13:33:53 -0000 @@ -6,7 +6,7 @@ startitem() findex(zcurses) cindex(windows, curses) -xitem(tt(zcurses) tt(-a) var(nlines) var(ncols) var(begin_y) var(begin_x) var(targetwin) ) +xitem(tt(zcurses) tt(-a) var(targetwin) var(nlines) var(ncols) var(begin_y) var(begin_x) ) xitem(tt(zcurses) tt(-d) var(targetwin) ) xitem(tt(zcurses) tt(-r) var(targetwin) ) xitem(tt(zcurses) tt(-m) var(targetwin) var(new_y) var(new_x) ) Index: Src/Modules/curses.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v retrieving revision 1.5 diff -u -r1.5 curses.c --- Src/Modules/curses.c 15 Oct 2007 13:30:10 -0000 1.5 +++ Src/Modules/curses.c 15 Oct 2007 13:33:53 -0000 @@ -105,14 +105,14 @@ if (OPT_ISSET(ops,'a')) { int nlines, ncols, begin_y, begin_x; - nlines = atoi(args[0]); - ncols = atoi(args[1]); - begin_y = atoi(args[2]); - begin_x = atoi(args[3]); - targetwin = zcurses_validate_window(args[4], ZCURSES_UNUSED); + targetwin = zcurses_validate_window(args[0], ZCURSES_UNUSED); + nlines = atoi(args[1]); + ncols = atoi(args[2]); + begin_y = atoi(args[3]); + begin_x = atoi(args[4]); if (targetwin == -1) { - zerrnam(nam, "%s: %s", zcurses_strerror(zc_errno), args[4], 0); + zerrnam(nam, "%s: %s", zcurses_strerror(zc_errno), args[0], 0); return 1; }