From: Clint Adams <clint@zsh.org>
To: Zsh Hackers' List <zsh-workers@sunsite.dk>
Subject: Re: PATCH: curses tweaks, maybe
Date: Sun, 21 Oct 2007 17:13:50 -0400 [thread overview]
Message-ID: <20071021211350.GA4528@scowler.net> (raw)
In-Reply-To: <20071020133709.GA15761@scowler.net>
On Sat, Oct 20, 2007 at 09:37:09AM -0400, Clint Adams wrote:
> This needs the checking bit and a doc update.
This is probably not the most efficient.
Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.15
diff -u -r1.15 curses.c
--- Src/Modules/curses.c 20 Oct 2007 13:40:02 -0000 1.15
+++ Src/Modules/curses.c 21 Oct 2007 21:08:54 -0000
@@ -281,7 +281,7 @@
{
char **saargs;
struct zcurses_subcommand *zcsc;
- int sc;
+ int sc, num_args;
struct zcurses_subcommand scs[] = {
{{"init", ZCURSES_SC_INIT}, 0, 0},
@@ -310,7 +310,13 @@
return 1;
}
- /* here would be a good place to validate number of args */
+ saargs = args;
+ while (*saargs++);
+ num_args = saargs - (args + 2);
+
+ if (num_args < zcsc->minargs || num_args > zcsc->maxargs)
+ return 1;
+
saargs = args + 1;
/* Initialise curses */
next prev parent reply other threads:[~2007-10-21 23:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 8:40 Peter Stephenson
2007-10-17 3:29 ` Clint Adams
2007-10-17 8:57 ` Peter Stephenson
2007-10-17 9:14 ` Peter Stephenson
2007-10-17 13:01 ` Clint Adams
2007-10-17 14:57 ` Bart Schaefer
2007-10-17 15:05 ` Peter Stephenson
2007-10-17 15:25 ` Clint Adams
2007-10-17 15:39 ` Peter Stephenson
2007-10-17 18:58 ` Clint Adams
2007-10-17 19:19 ` Clint Adams
2007-10-18 20:40 ` Clint Adams
2007-10-20 12:12 ` Peter Stephenson
2007-10-20 13:37 ` Clint Adams
2007-10-21 19:50 ` Clint Adams
2007-10-21 21:13 ` Clint Adams [this message]
2007-10-17 17:09 ` Bart Schaefer
2007-10-17 17:53 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071021211350.GA4528@scowler.net \
--to=clint@zsh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).