zsh-workers
 help / color / mirror / code / Atom feed
From: Vincent Lefevre <vincent@vinc17.org>
To: zsh-workers@sunsite.dk
Subject: Re: zsh 4.3.4 crashes in prompt-related code under Mac OS X
Date: Tue, 23 Oct 2007 13:54:16 +0200	[thread overview]
Message-ID: <20071023115416.GN3715@prunille.vinc17.org> (raw)
In-Reply-To: <200710221010.l9MAAuLw005609@news01.csr.com>

On 2007-10-22 11:10:55 +0100, Peter Stephenson wrote:
> Or maybe "shout" has got into some unusable state.  I suppose it's not
> unreasonable to test it's not NULL, although it's rather paranoid.

I don't know what is "shout", but I recall that the bug occurs only
after some command (ssh, called via a zsh wrapper function) has run
for several days. So, the environment had the time to change...

I've reinstalled zsh with the patch.

> --- Src/utils.c	5 Sep 2007 16:16:17 -0000	1.167
> +++ Src/utils.c	22 Oct 2007 10:09:41 -0000
> @@ -1160,7 +1160,7 @@
>      int period = getiparam("PERIOD");
>      int mailcheck = getiparam("MAILCHECK");
>  
> -    if (isset(PROMPTSP) && isset(PROMPTCR) && !use_exit_printed) {
> +    if (isset(PROMPTSP) && isset(PROMPTCR) && !use_exit_printed && shout) {

zsh 4.3.4 doesn't have !use_exit_printed, so I modified the above
lines in the following way:

-    if (isset(PROMPTSP) && isset(PROMPTCR)) {
+    if (isset(PROMPTSP) && isset(PROMPTCR) && !use_exit_printed && shout) {

-- 
Vincent Lefèvre <vincent@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)


  reply	other threads:[~2007-10-23 11:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-30  8:57 Vincent Lefevre
2007-08-30 15:12 ` Peter Stephenson
2007-10-20  2:54   ` Vincent Lefevre
2007-10-22 10:10     ` Peter Stephenson
2007-10-23 11:54       ` Vincent Lefevre [this message]
2007-10-23 11:58         ` Peter Stephenson
2007-11-01 14:23         ` Vincent Lefevre
2007-11-05 14:43           ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071023115416.GN3715@prunille.vinc17.org \
    --to=vincent@vinc17.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).