From: Peter Stephenson <pws@csr.com>
To: "Zsh Hackers' List" <zsh-workers@sunsite.dk>
Subject: Re: zsh-4.3.4-dev-2.tar.gz
Date: Wed, 21 Nov 2007 09:49:46 +0000 [thread overview]
Message-ID: <200711210949.lAL9nkch019465@news01.csr.com> (raw)
In-Reply-To: <20071121094036.GH1499@prunille.vinc17.org>
Vincent Lefevre wrote:
> Shouldn't HAVE_NCURSES_NCURSES_H and HAVE_NCURSES_H be reversed,
> in case both are defined? Indeed I assume that <ncurses/ncurses.h>
> should have the precedence over <ncurses.h> since the former is
> the canonical place, isn't it?
On the assumption that (i) only the original system packages are likely
to put the header in /usr/include (ii) added packages will put it in
some local subdirectory as ncurses/ncurses.h (iii) the added packages
should take preference and some attempt with include paths and library
paths has been made for this, then you're right. That's a little too
complicated for me to have much faith that it's always going to work,
but at least you've provided one example where it does.
Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.41
diff -u -r1.41 curses.c
--- Src/Modules/curses.c 20 Nov 2007 15:48:51 -0000 1.41
+++ Src/Modules/curses.c 21 Nov 2007 09:45:37 -0000
@@ -49,11 +49,11 @@
# ifdef HAVE_NCURSESW_NCURSES_H
# include <ncursesw/ncurses.h>
# else
-# ifdef HAVE_NCURSES_H
-# include <ncurses.h>
+# ifdef HAVE_NCURSES_NCURSES_H
+# include <ncurses/ncurses.h>
# else
-# ifdef HAVE_NCURSES_NCURSES_H
-# include <ncurses/ncurses.h>
+# ifdef HAVE_NCURSES_H
+# include <ncurses.h>
# else
# ifdef HAVE_CURSES_H
# include <curses.h>
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
prev parent reply other threads:[~2007-11-21 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11649.1195558694@csr.com>
[not found] ` <4742E805.5030402@math.technion.ac.il>
2007-11-20 14:08 ` zsh-4.3.4-dev-2.tar.gz Peter Stephenson
[not found] ` <4742DC87.5030901@math.technion.ac.il>
2007-11-20 14:14 ` zsh-4.3.4-dev-2.tar.gz Peter Stephenson
2007-11-20 15:03 ` zsh-4.3.4-dev-2.tar.gz Zvi Har'El
2007-11-20 15:11 ` zsh-4.3.4-dev-2.tar.gz Zvi Har'El
2007-11-20 15:42 ` zsh-4.3.4-dev-2.tar.gz Peter Stephenson
2007-11-20 15:59 ` zsh-4.3.4-dev-2.tar.gz Peter Stephenson
2007-11-21 9:40 ` zsh-4.3.4-dev-2.tar.gz Vincent Lefevre
2007-11-21 9:49 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711210949.lAL9nkch019465@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).