From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11683 invoked from network); 23 Nov 2007 00:01:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 23 Nov 2007 00:01:25 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 35881 invoked from network); 23 Nov 2007 00:01:16 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 23 Nov 2007 00:01:16 -0000 Received: (qmail 27676 invoked by alias); 23 Nov 2007 00:01:11 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24116 Received: (qmail 27656 invoked from network); 23 Nov 2007 00:01:09 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 23 Nov 2007 00:01:09 -0000 Received: (qmail 35537 invoked from network); 23 Nov 2007 00:01:09 -0000 Received: from g.primenet.com.au (203.24.36.10) by a.mx.sunsite.dk with SMTP; 23 Nov 2007 00:01:03 -0000 Received: (qmail 10109 invoked by uid 100); 23 Nov 2007 00:00:56 -0000 Date: Fri, 23 Nov 2007 11:00:56 +1100 From: Geoff Wing To: Zsh Hackers Subject: Re: PATCH: fix memory leak in new setenv code Message-ID: <20071123000056.GA6452@primenet.com.au> References: <20071122025711.GA4745@primenet.com.au> <071121234047.ZM6264@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <071121234047.ZM6264@torch.brasslantern.com> Organization: PrimeNet Computer Consultancy User-Agent: Mutt/1.5.17 (2007-11-01) On Thursday 2007-11-22 18:41 +1100, Bart Schaefer output: :On Nov 22, 1:57pm, Geoff Wing wrote: [...] : the memory in pm->env is not shared with the global environ [the :latter instead being left unchanged in that loop in createparamtable() :and thereafter mananged only by setenv()/unsetenv()]. OK, I guess that addresses my concern there. :So the patch below is at best incomplete. Try it with Oliver's :patch still in place and see if it resolves your corruption problem. Thanks, it does. Regards, Geoff