From: Guillaume Chazarain <guichaz@yahoo.fr>
To: Zsh Hackers' List <zsh-workers@sunsite.dk>
Subject: Re: deadlock caused by gettext usage in a signal handler
Date: Fri, 7 Dec 2007 00:02:07 +0100 [thread overview]
Message-ID: <20071207000207.2eb7e5e7@inria.fr> (raw)
In-Reply-To: <20071204203017.35a29727.p.w.stephenson@ntlworld.com>
Le Tue, 4 Dec 2007 20:30:17 +0000,
Peter Stephenson <p.w.stephenson@ntlworld.com> a écrit :
> That leaves me wondering if forking might be
> the problem; do we need to queue signals around there? It's not obvious
> why that would be.
It appears that glibc's fork is playing with locks:
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/nptl/sysdeps/unix/sysv/linux/fork.c?rev=1.11.2.3&content-type=text/x-cvsweb-markup&cvsroot=glibc
This patch solved the problem for me:
diff --git a/Src/exec.c b/Src/exec.c
index cf79ea8..6f16b9e 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -229,6 +229,7 @@ zfork(struct timeval *tv)
{
pid_t pid;
struct timezone dummy_tz;
+ sigset_t signals;
/*
* Is anybody willing to explain this test?
@@ -239,7 +240,10 @@ zfork(struct timeval *tv)
}
if (tv)
gettimeofday(tv, &dummy_tz);
+ sigfillset(&signals);
+ signals = signal_block(signals);
pid = fork();
+ signal_setmask(signals);
if (pid == -1) {
zerr("fork failed: %e", errno);
return -1;
Thanks.
--
Guillaume
next prev parent reply other threads:[~2007-12-06 23:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 19:35 Guillaume Chazarain
2007-12-03 22:43 ` Peter Stephenson
2007-12-04 1:39 ` Paul Ackersviller
2007-12-04 18:02 ` Guillaume Chazarain
2007-12-04 18:24 ` Peter Stephenson
2007-12-04 18:43 ` Guillaume Chazarain
2007-12-04 19:43 ` Peter Stephenson
2007-12-04 19:49 ` Guillaume Chazarain
2007-12-04 20:30 ` Peter Stephenson
2007-12-04 23:09 ` Guillaume Chazarain
2007-12-06 23:02 ` Guillaume Chazarain [this message]
2007-12-07 10:35 ` Peter Stephenson
2007-12-07 10:46 ` Guillaume Chazarain
2007-12-07 11:21 ` Bart Schaefer
2007-12-07 11:27 ` Peter Stephenson
2007-12-07 11:57 ` Guillaume Chazarain
2007-12-07 11:29 ` Peter Stephenson
2007-12-10 0:11 Paul Ackersviller
2007-12-10 2:04 ` Bart Schaefer
2007-12-10 3:17 ` Paul Ackersviller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071207000207.2eb7e5e7@inria.fr \
--to=guichaz@yahoo.fr \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).