From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25987 invoked from network); 8 Dec 2007 21:07:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 8 Dec 2007 21:07:53 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 15778 invoked from network); 8 Dec 2007 21:07:46 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 8 Dec 2007 21:07:46 -0000 Received: (qmail 14687 invoked by alias); 8 Dec 2007 21:07:37 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24189 Received: (qmail 14575 invoked from network); 8 Dec 2007 21:07:33 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 8 Dec 2007 21:07:33 -0000 Received: (qmail 15040 invoked from network); 8 Dec 2007 21:07:33 -0000 Received: from acolyte.scowler.net (216.254.112.45) by a.mx.sunsite.dk with SMTP; 8 Dec 2007 21:07:27 -0000 Received: by acolyte.scowler.net (Postfix, from userid 1000) id 4FBA75CE0E; Sat, 8 Dec 2007 16:07:25 -0500 (EST) Date: Sat, 8 Dec 2007 16:07:25 -0500 From: Clint Adams To: Vincent Lefevre , 455070@bugs.debian.org Cc: zsh-workers@sunsite.dk Subject: Re: Bug#455070: zsh: make completion: please add support for -include Message-ID: <20071208210725.GA25946@scowler.net> Mail-Followup-To: Vincent Lefevre , 455070@bugs.debian.org, zsh-workers@sunsite.dk References: <20071208195817.GA26694@vin.lip.ens-lyon.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071208195817.GA26694@vin.lip.ens-lyon.fr> User-Agent: Mutt/1.5.17 (2007-11-01) On Sat, Dec 08, 2007 at 08:58:17PM +0100, Vincent Lefevre wrote: > As shown below, "make" completion supports "include", > but not "-include". > > vin:~> head -99 Makefile* > ==> Makefile <== > test.b: test.a > touch $@ > > include Makefile-2 > > -include Makefile-3 > > ==> Makefile-2 <== > test.c: test.b > touch $@ > > ==> Makefile-3 <== > test.d: test.c > touch $@ > vin:~> make [TAB] > Completing make target > test.b test.c Could you give this completely-untested patch a try? Index: Completion/Unix/Command/_make =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_make,v retrieving revision 1.19 diff -u -r1.19 _make --- Completion/Unix/Command/_make 10 Nov 2006 09:59:27 -0000 1.19 +++ Completion/Unix/Command/_make 8 Dec 2007 21:06:29 -0000 @@ -125,7 +125,7 @@ _pick_variant -r is_gnu gnu=GNU unix -v -f if [[ $is_gnu = gnu ]]; then - incl=include + incl="(-|)include" else incl=.include fi