zsh-workers
 help / color / mirror / code / Atom feed
From: Clint Adams <clint@zsh.org>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh-workers@sunsite.dk
Subject: Re: git completion horribly slow in kernel tree
Date: Tue, 22 Jan 2008 11:22:22 -0500	[thread overview]
Message-ID: <20080122162222.GA503@scowler.net> (raw)
In-Reply-To: <237967ef0801211740s1ee07850vc25984a7af262cac@mail.gmail.com>

On Tue, Jan 22, 2008 at 02:40:03AM +0100, Mikael Magnusson wrote:
> Hm maybe my disclaimer wasn't clear enough, the code doesn't actually work.
> Specifically it doesn't complete anything after typing a partial
> directory name after a sha1: expression, so git show HEAD:<tab> will
> list all dirs and files, but HEAD:D<tab> won't complete to Doc.

This helps with that case.  Two things that are still broken are
1) suffix of completed directories is a space, not /
2) completion of dir/ won't work; you need to input the next letter
first.

Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.55
diff -u -r1.55 _git
--- Completion/Unix/Command/_git	22 Jan 2008 01:33:40 -0000	1.55
+++ Completion/Unix/Command/_git	22 Jan 2008 16:16:24 -0000
@@ -2655,8 +2655,7 @@
   integer at_least_one_tree_added
   local -a tree_files
 
-  Path=${1%/*}/
-  [[ $Path = / ]] && Path=.
+  Path=${1:h}/
   shift
   (( at_least_one_tree_added = 0 ))
   for tree in $*; do


  reply	other threads:[~2008-01-22 16:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-14 20:17 Jörg Sommer
2008-01-14 21:39 ` Mikael Magnusson
2008-01-22  1:19   ` Clint Adams
2008-01-22  1:40     ` Mikael Magnusson
2008-01-22 16:22       ` Clint Adams [this message]
2008-01-22 17:04         ` Clint Adams
2008-01-22 21:04           ` Nikolai Weibull
2008-01-22 21:16             ` Mikael Magnusson
2008-01-22 17:12         ` Clint Adams
2008-01-23 11:20           ` Mikael Magnusson
2008-01-23 13:29             ` Clint Adams
2008-01-23 16:30               ` Mikael Magnusson
2008-01-23 16:48                 ` Clint Adams
2008-01-23 17:03                   ` Mikael Magnusson
2008-01-24  6:46                   ` Mikael Magnusson
2008-01-24  7:20                     ` Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080122162222.GA503@scowler.net \
    --to=clint@zsh.org \
    --cc=mikachu@gmail.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).