From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20861 invoked from network); 1 Feb 2008 11:23:28 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 1 Feb 2008 11:23:28 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 49653 invoked from network); 1 Feb 2008 11:23:22 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 1 Feb 2008 11:23:22 -0000 Received: (qmail 12454 invoked by alias); 1 Feb 2008 11:23:20 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24507 Received: (qmail 12435 invoked from network); 1 Feb 2008 11:23:19 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 1 Feb 2008 11:23:19 -0000 Received: from cluster-g.mailcontrol.com (cluster-g.mailcontrol.com [85.115.41.190]) by bifrost.dotsrc.org (Postfix) with ESMTP id 9C95680482A1 for ; Fri, 1 Feb 2008 12:23:15 +0100 (CET) Received: from cameurexb01.EUROPE.ROOT.PRI ([62.189.241.200]) by rly13g.srv.mailcontrol.com (MailControl) with ESMTP id m11BMdAP004680 for ; Fri, 1 Feb 2008 11:23:00 GMT Received: from news01.csr.com ([10.103.143.38]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.1830); Fri, 1 Feb 2008 11:22:11 +0000 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.14.1/8.13.4) with ESMTP id m11BMB82025406 for ; Fri, 1 Feb 2008 11:22:11 GMT Received: from csr.com (pws@localhost) by news01.csr.com (8.14.1/8.14.1/Submit) with ESMTP id m11BMBdK025403 for ; Fri, 1 Feb 2008 11:22:11 GMT Message-Id: <200802011122.m11BMBdK025403@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk Subject: Re: ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]] In-reply-to: <20080201025428.GA17388@scowler.net> References: <20080108095306.5475d009@news01> <20080109191236.GB32394@scowler.net> <200801100950.m0A9oN9T015070@news01.csr.com> <20080115020642.GA5306@scowler.net> <200801150910.m0F9AP0f026468@news01.csr.com> <20080118170223.GA32039@scowler.net> <20080121014801.GA1242@primenet.com.au> <20080122013517.GD16813@scowler.net> <20080201025428.GA17388@scowler.net> Comments: In-reply-to Clint Adams message dated "Thu, 31 Jan 2008 21:54:28 -0500." Date: Fri, 01 Feb 2008 11:22:10 +0000 From: Peter Stephenson X-OriginalArrivalTime: 01 Feb 2008 11:22:11.0244 (UTC) FILETIME=[B0312EC0:01C864C4] X-Scanned-By: MailControl A-06-00-00 (www.mailcontrol.com) on 10.71.0.123 X-Virus-Scanned: ClamAV 0.91.2/5630/Fri Feb 1 10:56:57 2008 on bifrost X-Virus-Status: Clean Clint Adams wrote: > On Mon, Jan 21, 2008 at 08:35:17PM -0500, Clint Adams wrote: > > +VERSION="$VERSION$ZSH_VERSIONSUFFIX" > > So this actually doesn't work for reasons that should be obvious from > the ugly patch below. The suffix is lost in a ./config.status --recheck; > I don't know whether to view this as a feature or a bug. After updating the version in Config/version.mk and running make, I now have a top level Makefile containing: VERSION=4.3.5 VERSION_DATE='February 1, 2008' VERSION = 4.3.4-dev-8 so (i) the dependencies aren't right (ii) the new VERSION doesn't fit with the version generated from version.mk---the way to import a VERSION definition into makefiles and scripts is @VERSION_MK@. I suspect you want to do something like add ${ZSH_VERSIONSUFFIX} in version.mk (note this needs to work in both shell scripts and Makefiles). I don't want to wait yet more for 4.3.5, and obviously this isn't a problem for a production version (though multiple definitions of the version is), so I'll simply back this off for now. -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070