From: Clint Adams <clint@zsh.org>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh-workers <zsh-workers@sunsite.dk>
Subject: Re: gnu cut completion as wrong as it can be, patch
Date: Sun, 3 Feb 2008 13:07:47 -0500 [thread overview]
Message-ID: <20080203180747.GA14836@scowler.net> (raw)
In-Reply-To: <alpine.LNX.1.00.0802030821300.29268@localhost>
On Sun, Feb 03, 2008 at 08:22:35AM +0100, Mikael Magnusson wrote:
> Without linewrapping the patch...
This won't apply, with or without -l.
> --- a/Completion/Unix/Command/_cut
> +++ b/Completion/Unix/Command/_cut
> @@ -35,16 +35,17 @@ if _pick_variant gnu="Free Soft" unix --version; then
> esac
>
> _arguments \
> - '(--bytes -b)'{--bytes=,-b}'['$_cut_args[bytes]']' \
> - '(--characters -c)'{--characters=,-c}'['$_cut_args[characters]']' \
> - '(--delimiter -d)'{--delimiter=,-d}'['$_cut_args[delimiter]']' \
> - '(--fields -f)'{--fields=,-f}'['$_cut_args[fields]']' \
> + '(--bytes -b+)'{--bytes=,-b}'['$_cut_args[bytes]']:list' \
> + '(--characters -c+)'{--characters=,-c}'['$_cut_args[characters]']:list' \
> + '(--delimiter -d+)'{--delimiter=,-d}'['$_cut_args[delimiter]']:delimeter' \
> + '(--fields -f+)'{--fields=,-f}'['$_cut_args[fields]']:list' \
> '-n['$_cut_args[n]']' \
> '--complement['$_cut_args[complement]']' \
> - '(--only-delimited -s)'{--only-delimited=,-s}'['$_cut_args[only-delimited]']' \
> - '--output-delimiter['$_cut_args[output-delimiter]']' \
> + '(--only-delimited -s)'{--only-delimited,-s}'['$_cut_args[only-delimited]']' \
> + '--output-delimiter=['$_cut_args[output-delimiter]']:delimeter' \
> '--help['$_cut_args[help]']' \
> - '--version['$_cut_args[version]']'
> + '--version['$_cut_args[version]']' \
> + '*:file:_files'
> else
> _arguments \
> '-b[list specifies byte positions]:list:' \
I'm committing this; I'm not sure why you're putting + signs within the
parentheses.
Index: Completion/Unix/Command/_cut
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_cut,v
retrieving revision 1.4
diff -u -r1.4 _cut
--- Completion/Unix/Command/_cut 7 Dec 2007 17:03:32 -0000 1.4
+++ Completion/Unix/Command/_cut 3 Feb 2008 18:05:49 -0000
@@ -42,9 +42,10 @@
'-n['$_cut_args[n]']' \
'--complement['$_cut_args[complement]']' \
'(--only-delimited -s)'{--only-delimited=,-s}'['$_cut_args[only-delimited]']' \
- '--output-delimiter['$_cut_args[output-delimiter]']' \
+ '--output-delimiter=['$_cut_args[output-delimiter]']' \
'--help['$_cut_args[help]']' \
- '--version['$_cut_args[version]']'
+ '--version['$_cut_args[version]']' \
+ '*:file:_files'
else
_arguments \
'-b[list specifies byte positions]:list:' \
next prev parent reply other threads:[~2008-02-03 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-03 6:48 Mikael Magnusson
2008-02-03 7:22 ` Mikael Magnusson
2008-02-03 18:07 ` Clint Adams [this message]
2008-02-04 0:53 ` Mikael Magnusson
2008-02-06 1:23 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080203180747.GA14836@scowler.net \
--to=clint@zsh.org \
--cc=mikachu@gmail.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).