zsh-workers
 help / color / mirror / code / Atom feed
From: Andrey Borzenkov <arvidjaar@newmail.ru>
To: zsh-workers@sunsite.dk
Subject: Re: Phil's prompt is not working when LANG is set to UTF-8
Date: Fri, 15 Feb 2008 22:55:58 +0300	[thread overview]
Message-ID: <200802152255.59047.arvidjaar@newmail.ru> (raw)
In-Reply-To: <200802152249.00467.arvidjaar@newmail.ru>

[-- Attachment #1: Type: text/plain, Size: 1938 bytes --]

On Friday 15 February 2008, Andrey Borzenkov wrote:
> On Thursday 14 February 2008, Peter Stephenson wrote:
> > 
> > Wael Nasreddine wrote:
> > > Peter I couldn't install Fedora because it doesn't work with LVM over
> > > DM-Crypt, have you tried my environment ??
> > 
> > No, it seems unlikely I'm going to have time for that sort of
> > time-consuming procedure which is any case speculative.  It seems like
> > the next step is understanding the implications of Andrei's findings
> > since he's already narrowed it down.  I don't currently know anything
> > about the system he's talking about.
> > 
> 
> 
> I took liberty to move this to workers.
> 
> In case it rings the bell for anyone. Here are prompt lengths computed by
> zsh for phil's prompt in ru_RU.UTF-8 locale (where there were the same
> results for en_US.UTF-8 as well, so at least proper UTF-8 part is correctly
> computed :) )
> 
> (gdb) p rpromptw
> $1 = 12
> (gdb) p lpromptw
> $2 = 9
> (gdb) p lprompth
> $3 = 2
> (gdb) p rprompth
> $4 = 1
> 
> that's absolutely wrong. The actual prompt lengths are (see screenshot)
> 
> lpromptw = 13
> rptomptw = 16 (it has one space in it)
> 
> this perfectly correspnds to something (zsh?) ignoring invalid characters
> with high bit set.

For sure.

Src/prompt.c:countprompt()

            case MB_INVALID:
                memset(&mbs, 0, sizeof mbs);
                /* FALL THROUGH */
            case 0:
                /* Invalid character or null: assume no output. */
                multi = 0;
                break;

Oops.

I do not actually see how can we fix it except introducing prompt
expansion syntax for ACS (or may be for any terminfo sequence in general)
and simply assuming characters in any of them are of width 1.

> In both left and right prompts there are exactly 4 of 
> ACS chars.
> 
> I attach both left and ritgh prompts as well.
> 



[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2008-02-15 19:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080211033116.GD19613@phoenix.nasreddine.info>
     [not found] ` <20080214123757.GA2943@phoenix.nasreddine.info>
     [not found]   ` <200802141300.m1ED0qOo017425@news01.csr.com>
2008-02-15 19:48     ` Andrey Borzenkov
2008-02-15 19:55       ` Andrey Borzenkov [this message]
2008-02-15 20:10       ` Wael Nasreddine
2008-02-15 23:52 Fw: " Peter Stephenson
2008-02-16 19:13 ` Bart Schaefer
2008-02-17 16:43   ` Peter Stephenson
2008-02-17 17:40     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802152255.59047.arvidjaar@newmail.ru \
    --to=arvidjaar@newmail.ru \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).