From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16020 invoked from network); 26 Feb 2008 18:09:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 26 Feb 2008 18:09:44 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 52552 invoked from network); 26 Feb 2008 18:09:40 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 26 Feb 2008 18:09:40 -0000 Received: (qmail 7708 invoked by alias); 26 Feb 2008 18:09:38 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24598 Received: (qmail 7692 invoked from network); 26 Feb 2008 18:09:37 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 26 Feb 2008 18:09:37 -0000 Received: from cluster-g.mailcontrol.com (cluster-g.mailcontrol.com [85.115.41.190]) by bifrost.dotsrc.org (Postfix) with ESMTP id 62CAC8026E0B for ; Tue, 26 Feb 2008 19:09:29 +0100 (CET) Received: from rly08g.srv.mailcontrol.com (localhost.localdomain [127.0.0.1]) by rly08g.srv.mailcontrol.com (MailControl) with ESMTP id m1QI9Fx3000612 for ; Tue, 26 Feb 2008 18:09:21 GMT Received: from submission.mailcontrol.com (submission.mailcontrol.com [86.111.216.190]) by rly08g.srv.mailcontrol.com (MailControl) id m1QI8GUF024766 for zsh-workers@sunsite.dk; Tue, 26 Feb 2008 18:08:16 GMT Received: from cameurexb01.EUROPE.ROOT.PRI ([62.189.241.200]) by rly08g-eth0.srv.mailcontrol.com (envelope-sender Peter.Stephenson@csr.com) (MIMEDefang) with ESMTP id m1QI7vtn022806; Tue, 26 Feb 2008 18:08:15 +0000 (GMT) Received: from news01 ([10.103.143.38]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.3959); Tue, 26 Feb 2008 18:08:07 +0000 Date: Tue, 26 Feb 2008 18:08:07 +0000 From: Peter Stephenson To: zsh-workers@sunsite.dk Cc: Dagobert Michelsen Subject: Re: * Re: Failed tests of zsh 4.3.5 in Solaris 10 w/Sun Studio 12 CC Message-ID: <20080226180807.10cd1476@news01> In-Reply-To: <200802261610.m1QGAwJ3008939@news01.csr.com> References: <8AABEECB-A9A6-43EA-BED2-4BE376CBE349@blastwave.org> <20080226141459.76dc362c@news01> <20080226145741.6e74fc22@news01> <656429B3-438B-4ECF-85C4-04E38D837D1A@blastwave.org> <200802261610.m1QGAwJ3008939@news01.csr.com> Organization: CSR X-Mailer: Claws Mail 3.3.0 (GTK+ 2.12.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 26 Feb 2008 18:08:07.0780 (UTC) FILETIME=[8A256240:01C878A2] X-Scanned-By: MailControl A-08-00-04 (www.mailcontrol.com) on 10.71.1.118 X-Virus-Scanned: ClamAV 0.91.2/6003/Tue Feb 26 12:34:31 2008 on bifrost X-Virus-Status: Clean On Tue, 26 Feb 2008 16:10:58 +0000 Peter Stephenson wrote: > + if (!codessetstr || !*codsetstr || > + !strcmp(codesetstr, "646")) > + codesetstr == "US-ASCII"; Er, except that there are three mistakes in those three lines of code, as Geoff pointed out. I was lulled into a false sense of security because this doesn't get compiled on my machine. I tried it specially. Index: Src/utils.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/utils.c,v retrieving revision 1.178 diff -u -r1.178 utils.c --- Src/utils.c 26 Feb 2008 16:19:34 -0000 1.178 +++ Src/utils.c 26 Feb 2008 18:05:59 -0000 @@ -4885,9 +4885,9 @@ * It shouldn't ever be NULL, but while we're * being paranoid... */ - if (!codessetstr || !*codsetstr || + if (!codesetstr || !*codesetstr || !strcmp(codesetstr, "646")) - codesetstr == "US-ASCII"; + codesetstr = "US-ASCII"; cd = iconv_open(nl_langinfo(CODESET), "UCS-4BE"); if (cd == (iconv_t)-1) { zerr("cannot do charset conversion (iconv failed)"); -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070