yodl 2.11 and vpath problem

yodl 2.11 and vpath problem

[Clint Adams]

I'm not sure when this broke.

make[2]: Entering directory `/build/buildd/zsh-beta-4.3.5-dev-0+20080226/obj/Doc'
( \
	  echo 'IFDEF(INCWSLEVEL)(INCWSLEVEL())(STARTDEF())'; \
	  echo 'def(version)(0)('4.3.5-dev-0+0226')'; \
	  echo 'def(date)(0)(''February 1, 2008'')'; \
	  echo 'IFDEF(DECWSLEVEL)(DECWSLEVEL())(ENDDEF())#' | tr '#' '\\'; \
	) > ../../Doc/version.yo
yodl -o ../../Doc/zsh.1 -I../../Doc -w zman.yo version.yo ../../Doc/zsh.yo
Can't read `../../Doc/zsh.yo'

The reason it can't read that file is because it's looking in the wrong
directory:

open("../../Doc/zshzle.1", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 3
open("../../Doc/zshzle.idx", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 4
getcwd("/tmp/zsh-beta-4.3.5-dev-0+20080226/obj/Doc", 300) = 43
stat64("/tmp/zsh-beta-4.3.5-dev-0+20080226/obj/Doc/../../Doc/../../Doc/zshzle.yo", 0xbfde2044) = -1 ENOENT (No such file or directory)
stat64("/tmp/zsh-beta-4.3.5-dev-0+20080226/obj/Doc/../../Doc/../../Doc/zshzle.yo.yo", 0xbfde2044) = -1 ENOENT (No such file or directory)
write(2, "Can\'t read `../../Doc/zshzle.yo\'", 32Can't read `../../Doc/zshzle.yo

As one might expect,
yodl -o ../../Doc/zsh.1 -I../../Doc -w zman.yo version.yo Doc/zsh.yo
works.  I wouldn't expect -I to achieve that effect, and I suspect that
older versions behaved in the way the build system seems to expect, so
I'm going to file a bug on yodl.

Re: yodl 2.11 and vpath problem

[Clint Adams]

On Wed, Feb 27, 2008 at 10:50:51AM -0500, Clint Adams wrote:
> older versions behaved in the way the build system seems to expect, so
> I'm going to file a bug on yodl.

I take this back entirely. Maybe this behavior makes sense and we should
be either be passing -I$(srcdir):. or the path relative to
$(srcdir)/Doc.

Re: yodl 2.11 and vpath problem

[Peter Stephenson]

Clint Adams wrote:
> On Wed, Feb 27, 2008 at 10:50:51AM -0500, Clint Adams wrote:
> > older versions behaved in the way the build system seems to expect, so
> > I'm going to file a bug on yodl.
> 
> I take this back entirely. Maybe this behavior makes sense and we should
> be either be passing -I$(srcdir):. or the path relative to
> $(srcdir)/Doc.

-I$(srcdir) seems to be pretty reasonable to me, if that works.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: yodl 2.11 and vpath problem

[Clint Adams]

On Wed, Feb 27, 2008 at 05:27:19PM +0000, Peter Stephenson wrote:
> -I$(srcdir) seems to be pretty reasonable to me, if that works.

This patch, which I am committing, perhaps illustrates the issue better
than my description.

Index: Doc/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Makefile.in,v
retrieving revision 1.40
diff -u -r1.40 Makefile.in
--- Doc/Makefile.in	1 Feb 2008 11:31:38 -0000	1.40
+++ Doc/Makefile.in	27 Feb 2008 18:19:38 -0000
@@ -122,8 +122,8 @@
 	  *) target=$(sdir)/$@ ;; \
 	esac; \
 	case '$(YODL)' in :*) touch $$target ;; *) \
-	    echo $(YODL) -o $$target -I$(sdir) -w zman.yo version.yo $< ; \
-	    $(YODL) -I$(sdir) -w zman.yo version.yo $< | \
+	    echo $(YODL) -o $$target -I$(sdir):. -w zman.yo version.yo $< ; \
+	    $(YODL) -I$(sdir):. -w zman.yo version.yo $< | \
 	      sed -e '1s/\\-/-/g' -e '/^\.'\''/d' -e 's/\(\\fB\)*'\''/\1\\\&'\''/' > $$target \
 	;; esac; \