zsh-workers
 help / color / mirror / code / Atom feed
From: Clint Adams <clint@zsh.org>
To: zsh-workers@sunsite.dk
Cc: Romain Francoise <rfrancoise@debian.org>, 468386@bugs.debian.org
Subject: Re: Bug#468386: zsh-beta: Slow command completion
Date: Thu, 28 Feb 2008 13:24:02 -0500	[thread overview]
Message-ID: <20080228182402.GA24702@scowler.net> (raw)
In-Reply-To: <080228095414.ZM15685@torch.brasslantern.com> <200802281754.m1SHsSf1021072@news01.csr.com>

On Thu, Feb 28, 2008 at 05:54:28PM +0000, Peter Stephenson wrote:
> Limit the extra information for commands to people who *really* want it,
> by using another style ("extra_verbose") with an appropriate warning
> in the doc that this level of verbosity has speed implications.  The
> style is then reusable if this crops up elsewhere.

On Thu, Feb 28, 2008 at 09:54:14AM -0800, Bart Schaefer wrote:
> Or at least protect it with a style that is not generally set for any
> other purpose.

I went with a hyphen for consistency's sake.

Index: Completion/Unix/Type/_path_commands
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_path_commands,v
retrieving revision 1.2
diff -u -r1.2 _path_commands
--- Completion/Unix/Type/_path_commands	19 Feb 2008 22:52:22 -0000	1.2
+++ Completion/Unix/Type/_path_commands	28 Feb 2008 18:22:14 -0000
@@ -26,7 +26,7 @@
 _path_commands() {
 local need_desc expl ret=1
 
-if zstyle -T ":completion:${curcontext}:" verbose; then
+if zstyle -T ":completion:${curcontext}:" extra-verbose; then
   local update_policy first
   if [[ $+_command_descriptions -eq 0 ]]; then
     first=yes
Index: Doc/Zsh/compsys.yo
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Zsh/compsys.yo,v
retrieving revision 1.204
diff -u -r1.204 compsys.yo
--- Doc/Zsh/compsys.yo	23 Feb 2008 00:10:25 -0000	1.204
+++ Doc/Zsh/compsys.yo	28 Feb 2008 18:22:17 -0000
@@ -1672,6 +1672,12 @@
 tt(ignored-patterns) style, so they can be restored to consideration by
 the tt(_ignored) completer.
 )
+kindex(extra-verbose, completion style)
+item(tt(extra-verbose))(
+If set, the completion listing is more verbose at the cost of
+a probable decrease in completion speed.  Completion performance
+will suffer if this style is set to `true'.
+)
 kindex(ignored-patterns, completion style)
 item(tt(ignored-patterns))(
 A list of patterns; any trial completion matching one of the patterns


  reply	other threads:[~2008-02-28 18:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87zltldnde.fsf@elegiac.orebokech.com>
2008-02-28 17:27 ` Clint Adams
2008-02-28 17:54   ` Bart Schaefer
2008-03-02 15:07     ` Romain Francoise
2008-03-02 18:32       ` Bart Schaefer
2008-03-02 19:29         ` Romain Francoise
2008-03-02 20:52           ` Bart Schaefer
2008-03-02 21:46             ` Clint Adams
2008-03-02 22:45               ` Bart Schaefer
2008-03-02 23:02                 ` Clint Adams
2008-03-03  1:24                   ` Bart Schaefer
2008-03-03 15:46                     ` Oliver Kiddle
2008-02-28 17:54   ` Peter Stephenson
2008-02-28 18:24     ` Clint Adams [this message]
2008-02-29  1:11       ` Bart Schaefer
2008-02-29  2:07         ` Clint Adams
2008-02-29 17:12           ` Bart Schaefer
2008-03-01 23:06             ` Clint Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228182402.GA24702@scowler.net \
    --to=clint@zsh.org \
    --cc=468386@bugs.debian.org \
    --cc=rfrancoise@debian.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).