From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: Here-documents borked in "functions" output
Date: Fri, 14 Mar 2008 11:58:20 +0000 [thread overview]
Message-ID: <20080314115820.77d6e22a@news01> (raw)
In-Reply-To: <20080314113641.10398594@news01>
On Fri, 14 Mar 2008 11:36:41 +0000
Peter Stephenson <pws@csr.com> wrote:
> The new tests should catch most likely glitches.
However, there is a glitch in the quoting code; it's
independent of here-documents but there aren't many places
where we do this, so it hasn't shown up before:
% hello() {
cat <<HERE
I will `echo stuff` and then `echo more stuff`
HERE
}
% functions hello
hello () {
cat <<< "I will `echo stuff`` and then ``echo more stuff```"
}
Index: Src/utils.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/utils.c,v
retrieving revision 1.182
diff -u -r1.182 utils.c
--- Src/utils.c 27 Feb 2008 11:46:26 -0000 1.182
+++ Src/utils.c 14 Mar 2008 11:56:30 -0000
@@ -4268,6 +4268,8 @@
while (*u && *u != c)
*v++ = *u++;
*v++ = c;
+ if (*u)
+ u++;
continue;
} else if ((*u == Qstring || *u == '$') && u[1] == '\'' &&
instring == QT_DOUBLE) {
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-03-14 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 2:52 Bart Schaefer
2008-03-14 11:36 ` Peter Stephenson
2008-03-14 11:58 ` Peter Stephenson [this message]
2008-03-14 14:48 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080314115820.77d6e22a@news01 \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).