From: Peter Stephenson <pws@csr.com>
To: Baptiste Daroussin <baptiste.daroussin@gmail.com>,
zsh-workers@sunsite.dk
Cc: Pea <zsh@raveland.org>
Subject: Re: _canonical_path not working on *BSD
Date: Wed, 26 Mar 2008 15:05:52 +0000 [thread overview]
Message-ID: <20080326150552.52b3f1c4@news01> (raw)
In-Reply-To: <20080326114413.80713vrmznwpnyuc@bapt.selfip.org>
On Wed, 26 Mar 2008 11:44:13 +0100
Baptiste Daroussin <baptiste.daroussin@gmail.com> wrote:
> Hi,
>
> _canonical_path is not working on freebsd, it rely on readlink which
> does work the same on BSD :
> on openbsd -q options doesn't exist : umount[tab] gives readlink:
> unknown option -- q
> on freebsd readlink: illegal option -- q
Pea suggested just removing the -q, but probably we should also redirect
stderr:
Index: Completion/Unix/Type/_canonical_paths
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_canonical_paths,v
retrieving revision 1.1
diff -u -r1.1 _canonical_paths
--- Completion/Unix/Type/_canonical_paths 28 May 2006 18:36:06 -0000 1.1
+++ Completion/Unix/Type/_canonical_paths 26 Mar 2008 15:05:05 -0000
@@ -38,7 +38,8 @@
files=($@)
else
for __index in $@; do
- files+=$(readlink -qf $__index)
+ # BSD doesn't have -q, so redirect stderr.
+ files+=$(readlink -f $__index 2>/dev/null)
done
fi
@@ -48,7 +49,7 @@
expref=${~origpref}
[[ $origpref == (|*/). ]] && rltrim=.
curpref=${${expref%$rltrim}:-./}
- canpref=$(readlink -qf $curpref)
+ canpref=$(readlink -f $curpref 2>/dev/null)
if [[ $? -eq 0 ]]; then
[[ $curpref == */ && $canpref == *[^/] ]] && canpref+=/
canpref+=$rltrim
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-03-26 15:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 10:44 Baptiste Daroussin
2008-03-26 15:01 ` Debian bugs (Re: _canonical_path not working on *BSD) Bart Schaefer
2008-03-26 15:25 ` Clint Adams
2008-03-26 15:05 ` Peter Stephenson [this message]
2008-03-26 15:27 ` _canonical_path not working on *BSD Baptiste Daroussin
2008-03-26 15:34 ` Peter Stephenson
2008-03-26 15:51 ` Pea
2008-03-26 15:59 ` Clint Adams
2008-03-26 15:21 ` Pea
2008-03-26 15:36 ` Bart Schaefer
2008-03-26 15:40 ` Peter Stephenson
2008-03-26 16:04 ` Peter Stephenson
2008-03-26 16:18 ` Bart Schaefer
2008-03-26 16:21 ` Peter Stephenson
2008-03-26 16:38 ` Pea
2008-03-26 16:46 ` Peter Stephenson
2008-03-26 17:08 ` Pea
2008-03-26 17:17 ` Baptiste Daroussin
2008-03-27 10:23 ` Peter Stephenson
2008-03-27 11:08 ` Pea
2008-03-27 11:25 ` Peter Stephenson
2008-03-27 12:15 ` PATCH: cd -q (was Re: _canonical_path ...) Peter Stephenson
2008-03-27 12:25 ` Stephane Chazelas
2008-03-27 12:35 ` Mikael Magnusson
2008-03-27 12:48 ` Peter Stephenson
2008-03-27 12:56 ` Mikael Magnusson
2008-03-27 18:45 ` Peter Stephenson
2008-03-28 8:16 ` Pea
2008-03-28 11:01 ` Mikael Magnusson
2008-03-28 14:35 ` Peter Stephenson
2008-03-27 12:31 ` _canonical_path not working on *BSD Pea
2008-03-27 15:39 ` Bart Schaefer
2008-03-27 18:06 ` Peter Stephenson
2008-03-28 1:01 ` Bart Schaefer
2008-03-28 7:51 ` Mikael Magnusson
2008-03-28 10:01 ` Peter Stephenson
2008-03-26 16:25 ` Pea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326150552.52b3f1c4@news01 \
--to=pws@csr.com \
--cc=baptiste.daroussin@gmail.com \
--cc=zsh-workers@sunsite.dk \
--cc=zsh@raveland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).