From: Vincent Lefevre <vincent@vinc17.org>
To: zsh-workers@sunsite.dk
Subject: Re: Possible memory leak in hist.c
Date: Mon, 14 Apr 2008 16:42:19 +0200 [thread overview]
Message-ID: <20080414144219.GU1223@prunille.vinc17.org> (raw)
In-Reply-To: <200804141334.m3EDYRJj006753@news01.csr.com>
On 2008-04-14 14:34:27 +0100, Peter Stephenson wrote:
> It does look suspicious. However, we're currently using tmpfile to
> indicate whether we should be reporting an error about the temporary
> file, so without more work it looks like we can't actually remove the
> early frees.
If fact there are two "free(tmpfile);": one of them is followed
by a "err = 0" and for the other one, ret remains >= 0, so that
if tmpfile is freed, then no more messages can be output.
> They should certainly be setting tmpfile to NULL, though.
This solution may be cleaner, though.
--
Vincent Lefèvre <vincent@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)
prev parent reply other threads:[~2008-04-14 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 13:27 Vincent Lefevre
2008-04-14 13:34 ` Peter Stephenson
2008-04-14 14:42 ` Vincent Lefevre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414144219.GU1223@prunille.vinc17.org \
--to=vincent@vinc17.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).