From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19365 invoked from network); 17 Apr 2008 16:35:18 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 17 Apr 2008 16:35:18 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 43402 invoked from network); 17 Apr 2008 16:35:14 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 17 Apr 2008 16:35:14 -0000 Received: (qmail 13908 invoked by alias); 17 Apr 2008 16:35:12 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24832 Received: (qmail 13895 invoked from network); 17 Apr 2008 16:35:12 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 17 Apr 2008 16:35:12 -0000 Received: from cluster-d.mailcontrol.com (cluster-d.mailcontrol.com [217.69.20.190]) by bifrost.dotsrc.org (Postfix) with ESMTP id 4D2618043AC7 for ; Thu, 17 Apr 2008 18:35:09 +0200 (CEST) Received: from cameurexb01.EUROPE.ROOT.PRI ([62.189.241.200]) by rly27d.srv.mailcontrol.com (MailControl) with ESMTP id m3HGZ51b029456 for ; Thu, 17 Apr 2008 17:35:06 +0100 Received: from news01.csr.com ([10.103.143.38]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.3959); Thu, 17 Apr 2008 17:35:02 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.14.2/8.13.4) with ESMTP id m3HGZ3he007680 for ; Thu, 17 Apr 2008 17:35:03 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.14.2/8.14.2/Submit) with ESMTP id m3HGZ3dD007677 for ; Thu, 17 Apr 2008 17:35:03 +0100 Message-Id: <200804171635.m3HGZ3dD007677@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk Subject: Re: [PATCH] history locking with fcntl In-reply-to: <20080417162307.GB22594@blorf.net> References: <20080415153120.GE1223@prunille.vinc17.org> <20080417162307.GB22594@blorf.net> Comments: In-reply-to Wayne Davison message dated "Thu, 17 Apr 2008 09:23:07 -0700." Date: Thu, 17 Apr 2008 17:35:03 +0100 From: Peter Stephenson X-OriginalArrivalTime: 17 Apr 2008 16:35:02.0957 (UTC) FILETIME=[FC6645D0:01C8A0A8] X-Scanned-By: MailControl A-08-00-05 (www.mailcontrol.com) on 10.68.0.137 X-Virus-Scanned: ClamAV 0.91.2/6810/Thu Apr 17 13:25:25 2008 on bifrost X-Virus-Status: Clean Wayne Davison wrote: > I personally think this patch goes too far. There is a lockhistfile() > call that is done to give a particular shell exclusive control over the > history files. I'd prefer to see any extra locking done there. Sounds reasonable to me, but you have more idea of the structure of this bit. > Additional discussion: I think the option name should be made more > generic so that it can be made to support more types of file locking, > such as the flock() call. Perhaps call it HIST_EXTRA_LOCKING? I wondered about that, but something along the lines of Bart's concerns came to me. Consequently, I was quite happy with an option that read as THIS_IS_A_BIT_TECHY_AND_YOU_PROBABLY_OUGHT_TO_KNOW_WHAT_YOU_ARE_DONG rather than GREAT_NEW_OPTION_TRY_ME_TRY_ME. However, a suitably worded caveat in the documentation might be a better method. -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070