From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: vi-backward-kill-word
Date: Wed, 23 Apr 2008 09:32:55 +0100 [thread overview]
Message-ID: <200804230832.m3N8WtT2018739@news01.csr.com> (raw)
In-Reply-To: <C0AC3775-F880-40DF-BB43-F24321184707@kba.biglobe.ne.jp>
"Jun T." wrote:
> In vireplacechars(), line 545 (zle_vi.c),
> foredel(n - newchars, CUT_RAW);
>
> this will remove the base character "e" at zlecs, shift the
> combining character, and move zlecs to the next base char "o".
Yes, that needs to use shiftchars(), as I've already done in overwrite
mode.
Index: Src/Zle/zle_vi.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_vi.c,v
retrieving revision 1.20
diff -u -r1.20 zle_vi.c
--- Src/Zle/zle_vi.c 21 Apr 2008 17:30:36 -0000 1.20
+++ Src/Zle/zle_vi.c 23 Apr 2008 08:31:48 -0000
@@ -540,9 +540,11 @@
* Make sure we delete displayed characters, including
* attach combining characters. n includes this as a raw
* buffer offset.
+ * Use shiftchars so as not to adjust the cursor position;
+ * we are overwriting anything that remains directly.
*/
if (n > newchars)
- foredel(n - newchars, CUT_RAW);
+ shiftchars(zlecs, n - newchars);
else if (n < newchars)
spaceinline(newchars - n);
while (newchars--)
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-04-23 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 16:10 vi-backward-kill-word Jun T.
2008-04-21 17:27 ` vi-backward-kill-word Peter Stephenson
2008-04-21 17:57 ` vi-backward-kill-word Peter Stephenson
2008-04-22 17:56 ` vi-backward-kill-word Jun T.
2008-04-23 8:32 ` Peter Stephenson [this message]
2008-04-24 10:35 vi-backward-kill-word Jun T.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804230832.m3N8WtT2018739@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).