From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17952 invoked from network); 26 Apr 2008 20:51:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 26 Apr 2008 20:51:53 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 10746 invoked from network); 26 Apr 2008 20:51:49 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 26 Apr 2008 20:51:49 -0000 Received: (qmail 14093 invoked by alias); 26 Apr 2008 20:51:45 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24881 Received: (qmail 14073 invoked from network); 26 Apr 2008 20:51:44 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 26 Apr 2008 20:51:44 -0000 Received: from mtaout03-winn.ispmail.ntl.com (mtaout03-winn.ispmail.ntl.com [81.103.221.49]) by bifrost.dotsrc.org (Postfix) with ESMTP id 11C70808A38A for ; Sat, 26 Apr 2008 22:51:40 +0200 (CEST) Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout03-winn.ispmail.ntl.com with ESMTP id <20080426205553.KYEX19548.mtaout03-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com> for ; Sat, 26 Apr 2008 21:55:53 +0100 Received: from pws-pc.ntlworld.com ([81.107.40.67]) by aamtaout03-winn.ispmail.ntl.com with ESMTP id <20080426205851.NGIL26699.aamtaout03-winn.ispmail.ntl.com@pws-pc.ntlworld.com> for ; Sat, 26 Apr 2008 21:58:51 +0100 Received: from pws-pc (pws-pc [127.0.0.1]) by pws-pc.ntlworld.com (8.14.2/8.14.2) with ESMTP id m3QKp0WW030866 for ; Sat, 26 Apr 2008 21:51:00 +0100 Message-Id: <200804262051.m3QKp0WW030866@pws-pc.ntlworld.com> From: Peter Stephenson To: zsh-workers@sunsite.dk (Zsh hackers list) Subject: Re: PATCH: pattern incremental search In-Reply-To: Message from Peter Stephenson of "Sat, 26 Apr 2008 21:35:22 BST." <200804262035.m3QKZMIh029435@pws-pc.ntlworld.com> Date: Sat, 26 Apr 2008 21:51:00 +0100 X-Virus-Scanned: ClamAV 0.91.2/6957/Sat Apr 26 20:28:22 2008 on bifrost X-Virus-Status: Clean Feeping awful, part 2... I'll just commit any more I find on this scale without posting. There might be argument for even less feeping on invalid patterns. You do get a prompt, after all, and many complicated patterns go through this stage. Index: Src/Zle/zle_hist.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_hist.c,v retrieving revision 1.46 diff -u -r1.46 zle_hist.c --- Src/Zle/zle_hist.c 26 Apr 2008 20:40:18 -0000 1.46 +++ Src/Zle/zle_hist.c 26 Apr 2008 20:49:30 -0000 @@ -1179,8 +1179,10 @@ if (patprog) { revert_patpos = 1; } else { - handlefeep(zlenoargs); - nomatch = 2; + if (nomatch != 2) { + handlefeep(zlenoargs); + nomatch = 2; + } /* indicate "invalid" in status line */ memcpy(ibuf, INVALID_TEXT, BAD_TEXT_LEN); statusline = ibuf; -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/