From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26763 invoked from network); 29 Apr 2008 08:40:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 29 Apr 2008 08:40:44 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 62334 invoked from network); 29 Apr 2008 08:40:38 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 29 Apr 2008 08:40:38 -0000 Received: (qmail 18029 invoked by alias); 29 Apr 2008 08:40:36 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24893 Received: (qmail 18012 invoked from network); 29 Apr 2008 08:40:35 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 29 Apr 2008 08:40:35 -0000 Received: from cluster-d.mailcontrol.com (cluster-d.mailcontrol.com [217.69.20.190]) by bifrost.dotsrc.org (Postfix) with ESMTP id 72F0A808A38A for ; Tue, 29 Apr 2008 10:40:32 +0200 (CEST) Received: from cameurexb01.EUROPE.ROOT.PRI ([62.189.241.200]) by rly20d.srv.mailcontrol.com (MailControl) with ESMTP id m3T8eCeA020801 for ; Tue, 29 Apr 2008 09:40:23 +0100 Received: from news01 ([10.103.143.38]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.3959); Tue, 29 Apr 2008 09:40:09 +0100 Date: Tue, 29 Apr 2008 09:40:09 +0100 From: Peter Stephenson To: zsh-workers Subject: Re: describe-key-briefly crashes in cvs Message-ID: <20080429094009.473ea68e@news01> In-Reply-To: <237967ef0804281126x66554276o918f5b2ea0c105df@mail.gmail.com> References: <237967ef0804281126x66554276o918f5b2ea0c105df@mail.gmail.com> Organization: CSR X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 29 Apr 2008 08:40:09.0553 (UTC) FILETIME=[A1F6DC10:01C8A9D4] X-Scanned-By: MailControl A-08-50-00 (www.mailcontrol.com) on 10.68.0.130 X-Virus-Scanned: ClamAV 0.91.2/6982/Tue Apr 29 09:49:34 2008 on bifrost X-Virus-Status: Clean Probably I should never have made unmetafying in place the default behaviour for stringaszleline(). Index: Src/Zle/zle_refresh.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_refresh.c,v retrieving revision 1.62 diff -u -r1.62 zle_refresh.c --- Src/Zle/zle_refresh.c 26 Apr 2008 22:52:51 -0000 1.62 +++ Src/Zle/zle_refresh.c 29 Apr 2008 08:38:08 -0000 @@ -1418,8 +1418,9 @@ if (statusline) { int outll, outsz; + char *statusdup = ztrdup(statusline); ZLE_STRING_T outputline = - stringaszleline(statusline, 0, &outll, &outsz, NULL); + stringaszleline(statusdup, 0, &outll, &outsz, NULL); rpms.tosln = rpms.ln + 1; nbuf[rpms.ln][winw + 1] = zr_zr; /* text not wrapped */ @@ -1484,6 +1485,7 @@ snextline(&rpms); } zfree(outputline, outsz); + free(statusdup); } *rpms.s = zr_zr; -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070