From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-24920-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 18976 invoked from network); 5 May 2008 01:20:16 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.4
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns1.primenet.com.au with SMTP; 5 May 2008 01:20:16 -0000
Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts)
Received: (qmail 62110 invoked from network); 5 May 2008 01:20:12 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 5 May 2008 01:20:12 -0000
Received: (qmail 19371 invoked by alias); 5 May 2008 01:20:09 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 24920
Received: (qmail 19358 invoked from network); 5 May 2008 01:20:08 -0000
Received: from bifrost.dotsrc.org (130.225.254.106)
  by sunsite.dk with SMTP; 5 May 2008 01:20:08 -0000
Received: from dot.blorf.net (dsl-74-220-69-132.cruzio.com [74.220.69.132])
	by bifrost.dotsrc.org (Postfix) with ESMTP id 02F7580ED172
	for <zsh-workers@sunsite.dk>; Mon,  5 May 2008 03:20:04 +0200 (CEST)
Received: by dot.blorf.net (Postfix, from userid 1000)
	id A0309B23; Sun,  4 May 2008 18:20:54 -0700 (PDT)
Date: Sun, 4 May 2008 18:20:54 -0700
From: Wayne Davison <wayned@users.sourceforge.net>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: PATCH: optimise string conversions in history etc.
Message-ID: <20080505012054.GB11804@blorf.net>
References: <7816.1208725908@pws-pc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7816.1208725908@pws-pc>
User-Agent: Mutt/1.5.15+20070412 (2007-04-11)
X-Virus-Scanned: ClamAV 0.91.2/7028/Mon May  5 02:51:17 2008 on bifrost
X-Virus-Status: Clean

On Sun, Apr 20, 2008 at 10:11:48PM +0100, Peter Stephenson wrote:
> +	ret = mbrtowc(&wc, bufptr, charlen, &mbs);
> +	if (ret == 0) {
[...]
> +	}
> +	if (ret >= 0) {

Since ret is a size_t, "ret >= 0" is always true.  I've checked in a fix
for that.

Note that I catch things like this due to having more compiler warnings
enabled (-W):

--- configure.ac	4 May 2008 18:43:01 -0000	1.100
+++ configure.ac	5 May 2008 01:06:21 -0000
@@ -385,13 +385,13 @@ dnl   else use -O
 if test -n "$auto_cflags" && test ."$ansi2knr" != .yes; then
   if test "${enable_zsh_debug}" = yes; then
     if test -n "$GCC"; then
-      CFLAGS="$CFLAGS -Wall -Wmissing-prototypes -ggdb"
+      CFLAGS="$CFLAGS -Wall -W -Wno-unused-parameter -ggdb"
     else
       CFLAGS="$CFLAGS -g"
     fi
   else
     if test -n "$GCC"; then
-      CFLAGS="$CFLAGS -Wall -Wmissing-prototypes -O2"
+      CFLAGS="$CFLAGS -Wall -W -Wno-unused-parameter -O2"
     else
       CFLAGS="$CFLAGS -O"
     fi

If we want to commit a change like that, we'd need to ensure that
-Wno-unused-parameter was accepted by the compiler (since it wasn't
in older gcc versions).

..wayne..