From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13981 invoked from network); 7 May 2008 08:47:41 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 7 May 2008 08:47:41 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 86320 invoked from network); 7 May 2008 08:47:35 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 7 May 2008 08:47:35 -0000 Received: (qmail 18696 invoked by alias); 7 May 2008 08:47:31 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24959 Received: (qmail 18685 invoked from network); 7 May 2008 08:47:31 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 7 May 2008 08:47:31 -0000 Received: from cluster-d.mailcontrol.com (cluster-d.mailcontrol.com [217.69.20.190]) by bifrost.dotsrc.org (Postfix) with ESMTP id AE1D780ED174 for ; Wed, 7 May 2008 10:47:24 +0200 (CEST) Received: from rly15d.srv.mailcontrol.com (localhost.localdomain [127.0.0.1]) by rly15d.srv.mailcontrol.com (MailControl) with ESMTP id m478lNKU011415 for ; Wed, 7 May 2008 09:47:23 +0100 Received: from submission.mailcontrol.com (submission.mailcontrol.com [86.111.216.190]) by rly15d.srv.mailcontrol.com (MailControl) id m478kWU6006976 for zsh-workers@sunsite.dk; Wed, 7 May 2008 09:46:32 +0100 Received: from cameurexb01.EUROPE.ROOT.PRI ([62.189.241.200]) by rly15d-eth0.srv.mailcontrol.com (envelope-sender Peter.Stephenson@csr.com) (MIMEDefang) with ESMTP id m478k5UX003895; Wed, 07 May 2008 09:46:32 +0100 (BST) Received: from news01 ([10.103.143.38]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 May 2008 09:46:27 +0100 Date: Wed, 7 May 2008 09:46:26 +0100 From: Peter Stephenson To: "Hiroto Kagotani" , zsh-workers@sunsite.dk Subject: Re: Segmentation fault on Ctrl-D Message-ID: <20080507094626.437d7bc4@news01> In-Reply-To: References: Organization: CSR X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 07 May 2008 08:46:27.0641 (UTC) FILETIME=[D6A08290:01C8B01E] X-Scanned-By: MailControl A-08-50-01 (www.mailcontrol.com) on 10.68.1.125 X-Virus-Scanned: ClamAV 0.91.2/7046/Wed May 7 05:35:44 2008 on bifrost X-Virus-Status: Clean On Wed, 7 May 2008 16:35:05 +0900 "Hiroto Kagotani" wrote: > Hi there, > > I'm new to this list so please let me know if I'm missing any important > information. > > zsh (CVS, 4.3.6, 4.3.4 on FreeBSD, and 4.3.4 on Cygwin) crashes > when I type a key sequence followed by two Ctrl-D's. > > zsh -f > q<^D><^D> > -> Segmentation fault > > "q" may be any letter. If you have a lot of commands begin with the letter, > type three s to force zsh choose a candidate. Thanks. This was a very obvious mistake when I looked. Unfortunately old-fashion completion doesn't get the same level of testing as the new sort nowadays. Index: Src/Zle/compresult.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Zle/compresult.c,v retrieving revision 1.74 diff -u -r1.74 compresult.c --- Src/Zle/compresult.c 13 Apr 2008 16:58:42 -0000 1.74 +++ Src/Zle/compresult.c 7 May 2008 08:44:21 -0000 @@ -1188,6 +1188,12 @@ { int was_meta; + /* Just list the matches if the list was requested. */ + if (lst == COMP_LIST_COMPLETE) { + showinglist = -2; + return; + } + /* Already metafied when called from domenuselect already */ if (zlemetaline == NULL) { was_meta = 0; @@ -1195,12 +1201,6 @@ } else was_meta = 1; - /* Just list the matches if the list was requested. */ - if (lst == COMP_LIST_COMPLETE) { - showinglist = -2; - return; - } - /* Otherwise go to the next match in the array... */ do { if (!*++(minfo.cur)) { -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070