zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: "martin f. krafft" <madduck@debian.org>, zsh-workers@sunsite.dk
Subject: Re: [PATCH] typeset reply array
Date: Sun, 18 May 2008 18:17:35 +0100	[thread overview]
Message-ID: <20080518181735.1191bd8a@pws-pc> (raw)
In-Reply-To: <20080518053301.GA8521@scru.org>

On Sun, 18 May 2008 05:33:01 +0000
Clint Adams <schizo@debian.org> wrote:
> I think that some of these will break things. For example, if you keep 
> _comp_dumpfile local to compinit, when/if compinit calls compdump,
> problems might ensue.

Commonly used but non-global parameters such as "reply" could, and
probably should, be made local to the top-level of completion at around
the point where the options get set.  This would save them appearing in
the user's own space, which was the whole point of warncreateglobal in
the first place.

I don't think any special *internal* handling is warranted for
parameters that aren't themselves special to the shell.

A "typeset -g" for variables that *should* be global makes perfect
sense.  The "-g" should definitely be present even if the code isn't
inside a function (although the compinit stuff is), since we shouldn't
make that assumption.

> I don't know why we can't call compdump with an argument though.

I can't see why we shouldn't either.  I have a vague memory of wondering
that before.

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


  parent reply	other threads:[~2008-05-18 17:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1211026277-27464-1-git-send-email-madduck@debian.org>
     [not found] ` <1211026277-27464-2-git-send-email-madduck@debian.org>
     [not found]   ` <1211025324-25630-1-git-send-email-madduck@debian.org>
2008-05-18  5:33     ` Clint Adams
2008-05-18 16:40       ` Bart Schaefer
2008-05-18 16:49         ` martin f krafft
2008-05-18 17:17       ` Peter Stephenson [this message]
2008-05-18 19:23         ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080518181735.1191bd8a@pws-pc \
    --to=p.w.stephenson@ntlworld.com \
    --cc=madduck@debian.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).