From: Clint Adams <clint@zsh.org>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh-workers <zsh-workers@sunsite.dk>
Subject: Re: Fix a typo in _git.
Date: Sun, 17 Aug 2008 17:13:21 +0000 [thread overview]
Message-ID: <20080817171321.GA24334@scru.org> (raw)
In-Reply-To: <237967ef0808151656j7787f169g4b3456910e05bfc2@mail.gmail.com>
On Sat, Aug 16, 2008 at 01:56:36AM +0200, Mikael Magnusson wrote:
> http://git.mika.l3ib.org/?p=zsh-cvs.git;a=history;f=Completion/Unix/Command/_git;h=mika
Not committing this one; what's the advantage of for-each-ref and why
aren't you using _call_program?
From: Mikael Magnusson <mikachu@comhem.se>
Date: Fri, 6 Jun 2008 02:24:23 +0000 (+0200)
Subject: Use git-for-each-ref instead of git-branch/tag.
X-Git-Url: http://git.mika.l3ib.org:1234/?p=zsh-cvs.git;a=commitdiff_plain;h=48535f35f07a878630fb1aab122429dae8f95383
Use git-for-each-ref instead of git-branch/tag.
---
diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 974cb6c..f1261ab 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -2902,7 +2902,8 @@ __git_heads () {
local expl
declare -a branch_names
- branch_names=(${${(f)"$(_call_program heads git branch --no-color -a 2>/dev/null)"}#[* ] })
+ branch_names=(${${(f)"$(git for-each-ref --format='%(refname)' refs/heads refs/remotes 2>/dev/null)"}#refs/(heads|remotes)/})
+
__git_command_successful || return
_wanted heads expl branch-name compadd $* - $branch_names HEAD
@@ -2913,7 +2914,7 @@ __git_tags () {
local expl
declare -a tag_names
- tag_names=(${${(f)"$(_call_program tags git tag -l 2>/dev/null)"}#[* ] })
+ tag_names=(${${(f)"$(git for-each-ref --format='%(refname)' refs/tags 2>/dev/null)"}#refs/tags/})
__git_command_successful || return
_wanted tags expl tag-name compadd $* - $tag_names
@@ -2966,7 +2967,7 @@ __git_branch_names () {
local expl
declare -a branch_names
- branch_names=(${${(f)"$(_call_program branch-names git branch --no-color 2>/dev/null)"}#[* ] })
+ branch_names=(${${(f)"$(git for-each-ref --format='%(refname)' refs/heads 2>/dev/null)"}#refs/heads/})
__git_command_successful || return
_wanted branch-names expl branch-name compadd $* - $branch_names
next prev parent reply other threads:[~2008-08-17 17:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 23:56 Mikael Magnusson
2008-08-16 0:45 ` Clint Adams
2008-08-16 12:56 ` Clint Adams
2008-08-16 13:25 ` Clint Adams
2008-08-16 13:55 ` Clint Adams
2008-08-16 16:15 ` Clint Adams
2008-08-16 17:59 ` Clint Adams
2008-08-16 18:29 ` Clint Adams
2008-08-17 14:03 ` Clint Adams
2008-08-17 17:13 ` Clint Adams [this message]
2008-08-17 17:27 ` Mikael Magnusson
2008-08-18 1:46 ` Clint Adams
2008-08-18 9:47 ` Mikael Magnusson
2008-08-18 20:10 ` Mikael Magnusson
2008-08-18 22:45 ` Clint Adams
2008-08-19 0:09 ` Mikael Magnusson
2008-08-19 0:25 ` Clint Adams
2008-08-19 0:37 ` Mikael Magnusson
2008-08-19 0:39 ` Mikael Magnusson
2008-08-19 0:58 ` Clint Adams
2008-08-19 1:05 ` Clint Adams
2008-08-17 23:23 ` Mikael Magnusson
2008-08-17 23:30 ` Mikael Magnusson
2008-08-18 0:08 ` Phil Pennock
2008-08-19 1:08 ` Clint Adams
2008-08-19 1:41 ` Clint Adams
-- strict thread matches above, loose matches on Subject: below --
2007-10-18 21:23 Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080817171321.GA24334@scru.org \
--to=clint@zsh.org \
--cc=mikachu@gmail.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).