From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29813 invoked from network); 19 Aug 2008 01:05:59 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 19 Aug 2008 01:05:59 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 96762 invoked from network); 19 Aug 2008 01:05:55 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 19 Aug 2008 01:05:55 -0000 Received: (qmail 5505 invoked by alias); 19 Aug 2008 01:05:46 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25486 Received: (qmail 5488 invoked from network); 19 Aug 2008 01:05:44 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 19 Aug 2008 01:05:44 -0000 Received: from cork.scru.org (cork.scru.org [209.20.67.2]) by bifrost.dotsrc.org (Postfix) with ESMTPS id 6CB378058F37 for ; Tue, 19 Aug 2008 03:05:40 +0200 (CEST) Received: by cork.scru.org (Postfix, from userid 1000) id 38CB010408A; Tue, 19 Aug 2008 01:05:39 +0000 (UTC) Date: Tue, 19 Aug 2008 01:05:39 +0000 From: Clint Adams To: zsh-workers Subject: Re: Fix a typo in _git. Message-ID: <20080819010539.GB13979@scru.org> Mail-Followup-To: zsh-workers References: <237967ef0808151656j7787f169g4b3456910e05bfc2@mail.gmail.com> <20080817171321.GA24334@scru.org> <237967ef0808171027t4773ff36nb1cfe08942b63a5f@mail.gmail.com> <20080818014613.GA30193@scru.org> <237967ef0808180247l7b0ed485ob72df0a0637c57e9@mail.gmail.com> <237967ef0808181310kfa7128bt2e0321e77ad96d8f@mail.gmail.com> <20080818224510.GA12825@scru.org> <237967ef0808181709m1f6d6c5ao2311d960284f5c3f@mail.gmail.com> <20080819002511.GA13736@scru.org> <237967ef0808181737i29029b0kb170942152ff57fd@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <237967ef0808181737i29029b0kb170942152ff57fd@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Virus-Scanned: ClamAV 0.92.1/8056/Mon Aug 18 16:33:41 2008 on bifrost X-Virus-Status: Clean On Tue, Aug 19, 2008 at 02:37:34AM +0200, Mikael Magnusson wrote: > The man page and the command are both happy with -l -s. With recent git > versions, the -l option is always a no-op anyway... But in all honesty, > I think I just hadn't figured out what the (I) construction did then :). > It is still mystifying to me why _git-branch cares where on the command-line > the -v appears. You don't need the local -a shared anymore in that case either. Index: Completion/Unix/Command/_git =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v retrieving revision 1.80 diff -u -r1.80 _git --- Completion/Unix/Command/_git 19 Aug 2008 01:01:06 -0000 1.80 +++ Completion/Unix/Command/_git 19 Aug 2008 01:03:59 -0000 @@ -1590,20 +1590,16 @@ # TODO: The --no-checkout is undocumented. (( $+functions[_git-clone] )) || _git-clone () { - local -a shared - - if (( words[(I)(-l|--local)] )); then - shared=('(-s --shared)'{-s,--shared}'[share the objects with the source repository]') - fi _arguments \ '--bare[make a bare GIT repository]' \ '(-l --local)'{-l,--local}'[perform a local cloning of a repository]' \ - $shared \ + '(-s --shared)'{-s,--shared}'[share the objects with the source repository (warning: see man page)]' '--reference[reference repository]:repository:_directories' \ '(-q --quiet)'{-q,--quiet}'[operate quietly]' \ - '-n[do not checkout HEAD after clone is complete]' \ + '(-n --no-checkout)'{-n,--no-checkout}'[do not checkout HEAD after clone is complete]' \ '(-o --origin)'{-o,--origin}'[use given name instead of "origin" as branch name]:name:__git_guard_branch-name' \ + '--no-hardlinks[copy files instead of hardlinking when doing a local clone]' \ $upload_pack_arg \ $template_arg \ '--depth[create a shallow clone, given number of revisions deep]: :_guard "[[\:digit\:]]##" depth' \