From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12781 invoked from network); 28 Aug 2008 16:02:43 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 28 Aug 2008 16:02:43 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 68511 invoked from network); 28 Aug 2008 16:02:34 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 28 Aug 2008 16:02:34 -0000 Received: (qmail 6328 invoked by alias); 28 Aug 2008 16:02:25 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25538 Received: (qmail 6301 invoked from network); 28 Aug 2008 16:02:23 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 28 Aug 2008 16:02:23 -0000 Received: from mta-2.ms.rz.rwth-aachen.de (mta-2.ms.rz.RWTH-Aachen.DE [134.130.7.73]) by bifrost.dotsrc.org (Postfix) with ESMTPS id 79F2B80561C8 for ; Thu, 28 Aug 2008 18:02:20 +0200 (CEST) Received: from ironport-out-2.rz.rwth-aachen.de ([134.130.3.59]) by mta-2.ms.rz.RWTH-Aachen.de (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTP id <0K6B0078TJ7VROC0@mta-2.ms.rz.RWTH-Aachen.de> for zsh-workers@sunsite.dk; Thu, 28 Aug 2008 18:02:19 +0200 (CEST) Received: from relay.rwth-aachen.de ([134.130.3.1]) by ironport-in-2.rz.rwth-aachen.de with ESMTP; Thu, 28 Aug 2008 18:02:19 +0200 Received: from fsst.voodoo.lan ([212.117.84.217]) by relay.rwth-aachen.de (8.13.7/8.13.3/1) with ESMTP id m7SG2JVC005477 for ; Thu, 28 Aug 2008 18:02:19 +0200 (MEST) Received: from hawk by fsst.voodoo.lan with local (Exim 4.69) (envelope-from ) id 1KYjwX-0007TF-21 for zsh-workers@sunsite.dk; Thu, 28 Aug 2008 18:01:53 +0200 Date: Thu, 28 Aug 2008 18:01:52 +0200 From: Frank Terbeck Subject: PATCH: Fix a bug in _git's clone completion To: zsh workers Mail-followup-to: zsh workers Message-id: <20080828160152.GE6330@fsst.voodoo.lan> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 7BIT Content-disposition: inline X-IronPort-AV: E=Sophos;i="4.32,287,1217800800"; d="scan'208";a="53200101" User-Agent: Mutt/1.5.18 (2008-05-17) X-Virus-Scanned: ClamAV 0.92.1/8109/Thu Aug 28 16:33:58 2008 on bifrost X-Virus-Status: Clean There was a backslash missing at a line end, which screwed up things. Also, I don't understand the completion after 'git clone --bare '. It does not give me *any* completions, while I would expect the same completions as without the --bare option. If I do 'git clone --bare -', I only get a small subset of the remaining options. I don't know what is happening here. Finally, I do not understand why the end of the _arguments call was done like this: [snip] ':repository:__git_any_repositories' \- '*:directory:_directories' && ret=0- [snap] ...and not just: '*:repository:__git_any_repositories' && ret 0 If someone can explain, please do ahead. :) Index: Completion/Unix/Command/_git =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v retrieving revision 1.89 diff -u -r1.89 _git --- Completion/Unix/Command/_git 24 Aug 2008 19:48:09 -0000 1.89 +++ Completion/Unix/Command/_git 28 Aug 2008 15:51:53 -0000 @@ -1613,7 +1614,7 @@ _arguments \ '--bare[make a bare GIT repository]' \ '(-l --local)'{-l,--local}'[perform a local cloning of a repository]' \ - '(-s --shared)'{-s,--shared}'[share the objects with the source repository (warning: see man page)]' + '(-s --shared)'{-s,--shared}'[share the objects with the source repository (warning: see man page)]' \ '--reference[reference repository]:repository:_directories' \ '(-q --quiet)'{-q,--quiet}'[operate quietly]' \ '(-n --no-checkout)'{-n,--no-checkout}'[do not checkout HEAD after clone is complete]' \