* PATCH: curses null dereference risk
@ 2008-09-04 20:09 Clint Adams
0 siblings, 0 replies; only message in thread
From: Clint Adams @ 2008-09-04 20:09 UTC (permalink / raw)
To: zsh-workers; +Cc: eclark
If zca is NULL we don't want to try dereferencing it.
Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.45
diff -u -r1.45 curses.c
--- Src/Modules/curses.c 13 Mar 2008 11:11:04 -0000 1.45
+++ Src/Modules/curses.c 4 Sep 2008 20:08:07 -0000
@@ -948,14 +948,17 @@
if ((zca = zcurses_attrget(w->win, ptr)) == NULL) {
zwarnnam(nam, "attribute `%s' not known", ptr);
ret = 1;
- }
- switch(onoff) {
- case ZCURSES_ATTRON:
- ch |= zca->number;
- break;
- case ZCURSES_ATTROFF:
- ch &= ~zca->number;
- break;
+ } else {
+ switch(onoff) {
+ case ZCURSES_ATTRON:
+ if (wattron(w->win, zca->number) == ERR)
+ ret = 1;
+ break;
+ case ZCURSES_ATTROFF:
+ if (wattroff(w->win, zca->number) == ERR)
+ ret = 1;
+ break;
+ }
}
}
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-09-04 23:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-04 20:09 PATCH: curses null dereference risk Clint Adams
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).