From: Clint Adams <clint@zsh.org>
To: zsh-workers@sunsite.dk
Subject: PATCH: loadautofn memory leak
Date: Sun, 21 Sep 2008 12:45:30 +0000 [thread overview]
Message-ID: <20080921124530.GA31428@scru.org> (raw)
getfpfunc allocates memory for fname, which was not freed one these
codepaths.
Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.152
diff -u -r1.152 exec.c
--- Src/exec.c 16 Sep 2008 15:06:57 -0000 1.152
+++ Src/exec.c 21 Sep 2008 12:38:45 -0000
@@ -4134,10 +4134,13 @@
zwarn("%s: function definition file not found", shf->node.nam);
locallevel++;
popheap();
+ zsfree(fname);
return NULL;
}
- if (!prog)
+ if (!prog) {
+ zsfree(fname);
return NULL;
+ }
if (ksh == 2 || (ksh == 1 && isset(KSHAUTOLOAD))) {
if (autol) {
prog->flags |= EF_RUN;
@@ -4174,6 +4177,7 @@
shf->filename = fname;
}
popheap();
+ zsfree(fname);
return shf;
}
next reply other threads:[~2008-09-21 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 12:45 Clint Adams [this message]
2008-09-22 17:30 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080921124530.GA31428@scru.org \
--to=clint@zsh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).