Re: Minor VCS Info things

[Frank Terbeck <ft@bewatermyfriend.org>]

Peter Stephenson <pws@csr.com>:
> Some minor changes for VCS_Info I'd like to suggest, if they're
> uncontroversial.
[...]

I think all of these suggestions are the right thing to do.

> The Perforce detector doesn't work very well.  $P4CONFIG is not tied to
> being in the Perforce workspace: you can have a config file outside a
> workspace to set a default client etc., and you don't need one at all if
> the client etc. are set via environment variables.  The only good way of
> detecting whether you're in a workspace is to ask the server.
> Unfortunately this can hang (though not permanently) if the server is
> not available, so I haven't sent a patch.  It could be fixed by adding
> an explicit style to use the server and also a global (per server:port
> pair) flag that the server didn't respond, so that it only hangs (for a
> second or two) the first time.

I'm not familiar with perforce myself. I think it's safe to trust
people who actually use a system. The explicit style idea sounds nice
enough.

Whatever works for perforce users, we should do.

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925