From: Peter Stephenson <pws@csr.com>
To: "Zsh hackers list" <zsh-workers@sunsite.dk>
Subject: Re: fc (history) requires zsh is interactive? Why can't interactive toggled?
Date: Tue, 23 Sep 2008 09:42:49 +0100 [thread overview]
Message-ID: <20080923094249.073acbaa@news01> (raw)
In-Reply-To: <6cd6de210809222031n12743897l3e4474593a9a780a@mail.gmail.com>
On Mon, 22 Sep 2008 23:31:51 -0400
"Rocky Bernstein" <rocky.bernstein@gmail.com> wrote:
> I removed the interact test and played around with fc and don't see
> any difference.
I'm really only concerned with the non-interactive behaviour, which
probably only you have probed, so if you're happy with it there's probably
nothing major to worry about.
> Attached should be a two-line patch to #ifdef this code out. Apply it.
> If people find problems in fc as a result of this change, I'll fix
> these. If we get to a release and people for whatever reason feel the
> that life was better disallowing fc unless in interactive mode, then
> it is a matter of deleting two lines and you have the old behavior.
It seems unlikely that will be necessary if you haven't fallen over
anything horrible.
> I will also remove the interactive flag on zshdb as another means of
> getting test coverage there with a program that uses fc without
> interactive mode set.
>
> And to show good faith in fixing whatever bugs come up, attached is a
> test in an new "fc" file for the bug I recently discovered which by
> the way has nothing to do with whether or not interactive is set.
Thanks, both very useful. I've committed both the changes.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-09-23 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 0:37 Rocky Bernstein
2008-09-22 12:06 ` Peter Stephenson
2008-09-22 13:58 ` Rocky Bernstein
2008-09-22 14:25 ` Peter Stephenson
2008-09-23 3:31 ` Rocky Bernstein
2008-09-23 8:42 ` Peter Stephenson [this message]
2008-09-23 18:02 ` Rocky Bernstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923094249.073acbaa@news01 \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).