Re: Bug#501248: /usr/share/zsh/functions/Completion/compinstall: compinstall doesn't keep the previous configuration.

Re: Bug#501248: /usr/share/zsh/functions/Completion/compinstall: compinstall doesn't keep the previous configuration.

[Clint Adams]

On Mon, Oct 06, 2008 at 07:32:01AM +0900, Morita Sho wrote:
> Running compinstall will lost the setting that is previously configured using compinstall.
> 
> How to reproduce:
> 
>   % compinstall
>   ... Change some settings and exit.
>   % compinstall
>   ... All settings are reset to the default.
> 
> A message "Starting a new completion configuration from scratch." will be
> appears for every compinstall execution.
> 
> 
> It seems that there is a small typo in line 128 of
> /usr/share/zsh/functions/Completion/compinstall.
> 
>   [[ -z $newifile || ! -f $newfile ]] && foundold=false
>                            ^^^^^^^
> There is no such variable named $newfile in this file.
> I think it is a typo ("i" is missing) and it should be $newifile.

Thanks.

Index: Completion/compinstall
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/compinstall,v
retrieving revision 1.13
diff -u -r1.13 compinstall
--- Completion/compinstall	8 Jun 2008 17:53:54 -0000	1.13
+++ Completion/compinstall	6 Oct 2008 19:46:14 -0000
@@ -125,7 +125,7 @@
     newifile=$PWD/$newifile
     print "[Not absolute path: updating to $newifile]"
   fi
-  [[ -z $newifile || ! -f $newfile ]] && foundold=false
+  [[ -z $newifile || ! -f $newifile ]] && foundold=false
 else
   print "I haven't found any existing completion definitions.
 If you have some already defined by compinstall, edit the name of the