From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27528 invoked from network); 12 Oct 2008 11:00:51 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=AWL autolearn=unavailable version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 12 Oct 2008 11:00:51 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 99737 invoked from network); 12 Oct 2008 11:00:31 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 12 Oct 2008 11:00:31 -0000 Received: (qmail 12199 invoked by alias); 12 Oct 2008 11:00:17 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25857 Received: (qmail 12178 invoked from network); 12 Oct 2008 11:00:14 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 12 Oct 2008 11:00:14 -0000 Received: from cork.scru.org (cork.scru.org [209.20.67.2]) by bifrost.dotsrc.org (Postfix) with ESMTPS id A1C0480524C0 for ; Sun, 12 Oct 2008 12:59:59 +0200 (CEST) Received: by cork.scru.org (Postfix, from userid 1000) id 079A21040BC; Sun, 12 Oct 2008 10:59:58 +0000 (UTC) Date: Sun, 12 Oct 2008 10:59:57 +0000 From: Clint Adams To: Mikael Magnusson Cc: zsh workers Subject: Re: [PATCH 2/2] Fix typos in completion style guide. Message-ID: <20081012105957.GA14857@scru.org> Mail-Followup-To: Mikael Magnusson , zsh workers References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Virus-Scanned: ClamAV 0.92.1/8414/Sun Oct 12 05:30:50 2008 on bifrost X-Virus-Status: Clean On Sun, Oct 12, 2008 at 11:24:23AM +0200, Mikael Magnusson wrote: > --- > Etc/completion-style-guide | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Etc/completion-style-guide b/Etc/completion-style-guide This one broke because of wrapping. Hand-applied; you can check what I've missed this time below: Index: Etc/completion-style-guide =================================================================== RCS file: /cvsroot/zsh/zsh/Etc/completion-style-guide,v retrieving revision 1.8 diff -u -r1.8 completion-style-guide --- Etc/completion-style-guide 23 Jul 2003 11:06:59 -0000 1.8 +++ Etc/completion-style-guide 12 Oct 2008 10:58:14 -0000 @@ -8,7 +8,7 @@ Coding style: * Use two spaces for indentation and four for continuation lines except - where there are many continutation lines such as `_arguments' or + where there are many continuation lines such as `_arguments' or `_values' specs. Lines tend to be longer than in C code so less indentation makes sense. @@ -46,7 +46,7 @@ per-match descriptions; they are better placed in the group descriptions. Put the units in parentheses after the description. So for example, do not use: - '--timeout[specifiy connection timeout in milliseconds]:timeout' + '--timeout[specify connection timeout in milliseconds]:timeout' but use: '--timeout[specify connection timeout]:timeout (ms)' @@ -63,7 +63,7 @@ Where two matches have identical meaning, give them the same description so that the completion system can group them together. -Conventionally a brace exapansion of this form is used: +Conventionally a brace expansion of this form is used: '(--context,-C)'{--context=,-C-}'[specify lines of context]:lines' You won't need the exclusion list if the option can be specified multiple times. It can also be useful to use the same description for