zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: "Zsh Hackers' List" <zsh-workers@sunsite.dk>
Subject: Re: Regression in braces completion
Date: Sun, 12 Oct 2008 20:42:36 +0100	[thread overview]
Message-ID: <20081012204236.6669a668@pws-pc> (raw)
In-Reply-To: <081012001051.ZM30706@torch.brasslantern.com>

On Sun, 12 Oct 2008 00:10:51 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> (That took *way* longer to track down than it should have, because I
> didn't realize just how *many* calls to "compadd -U" there are, and I
> missed the crucial one the first time and ended up chasing a different
> red herring for an hour.  Oy.)

I don't know what they're all doing, either.

> Removing the -U *only* from the compadd on line 634 of _path_files is
> sufficient to fix this particular example, but I wonder if it should be
> removed from all three of the compadd calls in the "we are listing, or
> something" branch (see comment line 605), or if it needs to be omitted
> based on some other condition ... or if we need to know when spelling
> correction has been done so we can only add -U when we have to, or some
> even more complicated set of conditions.

There will be an underlying reason why this particular case inserts the
brace in the wrong place.  It will take many hours of work to find out.

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


  reply	other threads:[~2008-10-12 19:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-12  2:32 Vin Shelton
2008-10-12  4:32 ` Bart Schaefer
2008-10-12  7:10   ` Bart Schaefer
2008-10-12 19:42     ` Peter Stephenson [this message]
2008-10-12 22:47       ` Bart Schaefer
2008-10-13  9:04         ` Peter Stephenson
2008-10-13 15:43           ` Bart Schaefer
2008-10-13 16:27             ` Peter Stephenson
2008-10-13 16:56               ` Bart Schaefer
2008-10-14  4:37               ` PATCH (?) " Bart Schaefer
2008-10-14  8:45                 ` Peter Stephenson
2008-10-15  1:34                   ` Vin Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081012204236.6669a668@pws-pc \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).