From: Peter Stephenson <pws@csr.com>
To: "Zsh Hackers' List" <zsh-workers@sunsite.dk>
Subject: Re: PATCH (?) Re: Regression in braces completion
Date: Tue, 14 Oct 2008 09:45:12 +0100 [thread overview]
Message-ID: <200810140845.m9E8jCDN025543@news01.csr.com> (raw)
In-Reply-To: <081013213720.ZM30875@torch.brasslantern.com>
Bart Schaefer wrote:
> Somebody tell me what's wrong with this. Doesn't seem to break spelling
> correction in the path prefix when braces are present, and doesn't seem
> to break braces when spelling correction isn't present, and doesn't add
> any new calls to compadd; just changes whether the ones that are there
> get -U passed in.
>
> What am I missing?
Presumably we won't know for months until somebody tries the completion
in question, but if this seems to fix all the obvious problems feel free
to commit it, since I wasn't going to have much time to look at
compresult.c anyway. (It might, for example, break spelling correction
where the prefix itself is in braces, but I don't feel particularly
moved to experiment.)
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-10-14 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 2:32 Vin Shelton
2008-10-12 4:32 ` Bart Schaefer
2008-10-12 7:10 ` Bart Schaefer
2008-10-12 19:42 ` Peter Stephenson
2008-10-12 22:47 ` Bart Schaefer
2008-10-13 9:04 ` Peter Stephenson
2008-10-13 15:43 ` Bart Schaefer
2008-10-13 16:27 ` Peter Stephenson
2008-10-13 16:56 ` Bart Schaefer
2008-10-14 4:37 ` PATCH (?) " Bart Schaefer
2008-10-14 8:45 ` Peter Stephenson [this message]
2008-10-15 1:34 ` Vin Shelton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810140845.m9E8jCDN025543@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).