From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26562 invoked from network); 14 Oct 2008 08:46:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=AWL autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 14 Oct 2008 08:46:25 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 86327 invoked from network); 14 Oct 2008 08:46:05 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 14 Oct 2008 08:46:05 -0000 Received: (qmail 19763 invoked by alias); 14 Oct 2008 08:45:49 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25888 Received: (qmail 19738 invoked from network); 14 Oct 2008 08:45:46 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 14 Oct 2008 08:45:46 -0000 Received: from cluster-g.mailcontrol.com (cluster-g.mailcontrol.com [208.87.233.190]) by bifrost.dotsrc.org (Postfix) with ESMTPS id D7D0980524C0 for ; Tue, 14 Oct 2008 10:45:30 +0200 (CEST) Received: from cameurexb01.EUROPE.ROOT.PRI ([193.128.72.68]) by rly23g.srv.mailcontrol.com (MailControl) with ESMTP id m9E8j6eO014716 for ; Tue, 14 Oct 2008 09:45:26 +0100 Received: from news01.csr.com ([10.103.143.38]) by cameurexb01.EUROPE.ROOT.PRI with Microsoft SMTPSVC(6.0.3790.3959); Tue, 14 Oct 2008 09:45:13 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.14.2/8.13.4) with ESMTP id m9E8jDWu025547 for ; Tue, 14 Oct 2008 09:45:13 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.14.2/8.14.2/Submit) with ESMTP id m9E8jCDN025543 for ; Tue, 14 Oct 2008 09:45:13 +0100 Message-Id: <200810140845.m9E8jCDN025543@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: "Zsh Hackers' List" Subject: Re: PATCH (?) Re: Regression in braces completion In-reply-to: <081013213720.ZM30875@torch.brasslantern.com> References: <20a807210810111932r1b32b746l3cca788a383e84ed@mail.gmail.com> <081011213249.ZM29979@torch.brasslantern.com> <081012001051.ZM30706@torch.brasslantern.com> <20081012204236.6669a668@pws-pc> <081012154721.ZM22722@torch.brasslantern.com> <20081013100417.36870ba5@news01> <081013084328.ZM28630@torch.brasslantern.com> <200810131627.m9DGRoED017498@news01.csr.com> <081013213720.ZM30875@torch.brasslantern.com> Comments: In-reply-to Bart Schaefer message dated "Mon, 13 Oct 2008 21:37:20 -0700." Date: Tue, 14 Oct 2008 09:45:12 +0100 From: Peter Stephenson X-OriginalArrivalTime: 14 Oct 2008 08:45:13.0593 (UTC) FILETIME=[2C95AE90:01C92DD9] X-Scanned-By: MailControl A-08-50-15 (www.mailcontrol.com) on 10.71.0.133 X-Virus-Scanned: ClamAV 0.92.1/8421/Tue Oct 14 09:23:51 2008 on bifrost X-Virus-Status: Clean Bart Schaefer wrote: > Somebody tell me what's wrong with this. Doesn't seem to break spelling > correction in the path prefix when braces are present, and doesn't seem > to break braces when spelling correction isn't present, and doesn't add > any new calls to compadd; just changes whether the ones that are there > get -U passed in. > > What am I missing? Presumably we won't know for months until somebody tries the completion in question, but if this seems to fix all the obvious problems feel free to commit it, since I wasn't going to have much time to look at compresult.c anyway. (It might, for example, break spelling correction where the prefix itself is in braces, but I don't feel particularly moved to experiment.) -- Peter Stephenson Software Engineer CSR PLC, Churchill House, Cambridge Business Park, Cowley Road Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070