From: Clint Adams <clint@zsh.org>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: use after free in setstrvalue
Date: Thu, 23 Oct 2008 00:46:32 +0000 [thread overview]
Message-ID: <20081023004632.GA30506@scru.org> (raw)
In-Reply-To: <20080913081628.GA25022@scru.org>
On Sat, Sep 13, 2008 at 08:16:28AM +0000, Clint Adams wrote:
> - zsfree(val);
> if ((v->pm->node.flags & (PM_LEFT | PM_RIGHT_B | PM_RIGHT_Z)) &&
> !v->pm->width)
> v->pm->width = strlen(val);
> + zsfree(val);
Should have done this one too..
Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.149
diff -u -r1.149 params.c
--- Src/params.c 9 Oct 2008 13:46:45 -0000 1.149
+++ Src/params.c 23 Oct 2008 00:45:00 -0000
@@ -2253,10 +2253,10 @@
mnumber mn = matheval(val);
v->pm->gsu.f->setfn(v->pm, (mn.type & MN_FLOAT) ? mn.u.d :
(double)mn.u.l);
- zsfree(val);
if ((v->pm->node.flags & (PM_LEFT | PM_RIGHT_B | PM_RIGHT_Z)) &&
!v->pm->width)
v->pm->width = strlen(val);
+ zsfree(val);
}
break;
case PM_ARRAY:
prev parent reply other threads:[~2008-10-23 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 8:16 Clint Adams
2008-10-23 0:46 ` Clint Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023004632.GA30506@scru.org \
--to=clint@zsh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).