From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6684 invoked from network); 31 Oct 2008 21:08:26 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 31 Oct 2008 21:08:26 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 10736 invoked from network); 31 Oct 2008 21:08:20 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 31 Oct 2008 21:08:20 -0000 Received: (qmail 29523 invoked by alias); 31 Oct 2008 21:08:14 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25984 Received: (qmail 29513 invoked from network); 31 Oct 2008 21:08:13 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 31 Oct 2008 21:08:13 -0000 Received: from mtaout01-winn.ispmail.ntl.com (mtaout01-winn.ispmail.ntl.com [81.103.221.47]) by bifrost.dotsrc.org (Postfix) with ESMTP id 7715480524C0 for ; Fri, 31 Oct 2008 22:08:10 +0100 (CET) Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20081031210810.FFWC21227.mtaout01-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com> for ; Fri, 31 Oct 2008 21:08:10 +0000 Received: from pws-pc.ntlworld.com ([81.107.43.40]) by aamtaout03-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20081031210809.HTOS2093.aamtaout03-winn.ispmail.ntl.com@pws-pc.ntlworld.com> for ; Fri, 31 Oct 2008 21:08:09 +0000 Received: from pws-pc (pws-pc [127.0.0.1]) by pws-pc.ntlworld.com (8.14.2/8.14.2) with ESMTP id m9VL7v7Y003700 for ; Fri, 31 Oct 2008 21:07:57 GMT Message-Id: <200810312107.m9VL7v7Y003700@pws-pc.ntlworld.com> From: Peter Stephenson To: Zsh workers Subject: Re: PATCH: bug with hash builtin In-Reply-To: Message from Oliver Kiddle of "Fri, 31 Oct 2008 12:10:25 +0100." <23054.1225451425@thecus> Date: Fri, 31 Oct 2008 21:07:57 +0000 X-Cloudmark-Analysis: v=1.0 c=1 a=NLZqzBF-AAAA:8 a=GEG3U0Z-ul_zpnO5D7AA:9 a=LczWrPdl_n5tuscODoNdqYxG6FUA:4 a=_dQi-Dcv4p4A:10 a=p2VOdof_XD0A:10 X-Virus-Scanned: ClamAV 0.92.1/8550/Fri Oct 31 19:34:18 2008 on bifrost X-Virus-Status: Clean Oliver Kiddle wrote: > This was found by coverity: > > hash = > causes a seg fault. > > A patch is below. I'm not sure about the error message because it isn't > really an assignment but I can't think of anything better. Does anyone > think it would be better to avoid the use of the continue statement here > at the cost of having to further indent quite a few lines. It looks OK to me. -- Peter Stephenson Web page now at http://homepage.ntlworld.com/p.w.stephenson/