From: Stephane Chazelas <Stephane_Chazelas@yahoo.fr>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: [PATCH] Re: f() { ...; } > file
Date: Thu, 13 Nov 2008 14:42:12 +0000 [thread overview]
Message-ID: <20081113144212.GB5114@sc.homeunix.net> (raw)
In-Reply-To: <20081105212036.GA4698@sc.homeunix.net>
On Wed, Nov 05, 2008 at 09:20:36PM +0000, Stephane Chazelas wrote:
[...]
> $ bash -c 'foo() { echo a >&3; } 3>&1; foo'
> a
> $ ksh -c 'foo() { echo a >&3; } 3>&1; foo'
> a
> $ zsh -c 'foo() { echo a >&3; } 3>&1; foo'
> foo: 3: bad file descriptor
> $ ARGV0=sh zsh -c 'foo() { command echo a >&3; } 3>&1; foo'
> foo: 3: bad file descriptor
>
> It looks like zsh evaluates the redirection at the time the
> function is defined rather than when it is called.
>
> It's OK when declaring the function as
>
> foo() echo a > file
> or
> foo() (echo a) > file
>
> instead of
>
> foo() { echo a; } > file
[...]
The patch below seems to fix it. It just removes the special
case of f() { }. I don't why it was there in the first place.
rev 1.1 of parse.c already had it.
Not sure how many things this patch would break ;)
Index: Src/parse.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/parse.c,v
retrieving revision 1.76
diff -p -u -r1.76 parse.c
--- Src/parse.c 29 Sep 2008 08:46:33 -0000 1.76
+++ Src/parse.c 13 Nov 2008 14:31:10 -0000
@@ -1685,34 +1685,20 @@ par_simple(int *complex, int nr)
onp = ecnpats;
ecnpats = 0;
- if (tok == INBRACE) {
- int c = 0;
+ int ll, sl, pl, c = 0;
- yylex();
- par_list(&c);
- if (tok != OUTBRACE) {
- cmdpop();
- lineno += oldlineno;
- ecnpats = onp;
- ecssub = oecssub;
- YYERROR(oecused);
- }
- yylex();
- } else {
- int ll, sl, pl, c = 0;
-
- ll = ecadd(0);
- sl = ecadd(0);
- pl = ecadd(WCB_PIPE(WC_PIPE_END, 0));
-
- if (!par_cmd(&c)) {
- cmdpop();
- YYERROR(oecused);
- }
-
- set_sublist_code(sl, WC_SUBLIST_END, 0, ecused - 1 - sl, c);
- set_list_code(ll, (Z_SYNC | Z_END), c);
+ ll = ecadd(0);
+ sl = ecadd(0);
+ pl = ecadd(WCB_PIPE(WC_PIPE_END, 0));
+
+ if (!par_cmd(&c)) {
+ cmdpop();
+ YYERROR(oecused);
}
+
+ set_sublist_code(sl, WC_SUBLIST_END, 0, ecused - 1 - sl, c);
+ set_list_code(ll, (Z_SYNC | Z_END), c);
+
cmdpop();
ecadd(WCB_END());
--
Stéphane
next prev parent reply other threads:[~2008-11-13 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 21:20 Stephane Chazelas
2008-11-05 22:49 ` Phil Pennock
2008-11-06 14:38 ` Stephane Chazelas
2008-11-13 14:25 ` Stephane Chazelas
2008-11-13 14:42 ` Stephane Chazelas [this message]
2008-11-13 14:52 ` [PATCH] " Peter Stephenson
2008-11-13 15:03 ` Stephane Chazelas
2008-11-13 15:13 ` Stephane Chazelas
2008-11-13 15:27 ` Peter Stephenson
2008-11-13 14:55 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113144212.GB5114@sc.homeunix.net \
--to=stephane_chazelas@yahoo.fr \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).