zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: [PATCH] Re: f() { ...; } > file
Date: Thu, 13 Nov 2008 14:52:59 +0000	[thread overview]
Message-ID: <200811131452.mADEqx9i030855@news01.csr.com> (raw)
In-Reply-To: <20081113144212.GB5114@sc.homeunix.net>

Stephane Chazelas wrote:
> The patch below seems to fix it. It just removes the special
> case of f() { }. I don't why it was there in the first place.
> rev 1.1 of parse.c already had it.

That's because you've made all functions with braces parse as if they
contain current shell structures; you'll see they're output with an
unnecessary extra set of "{"s.  This works because it just makes the
code behave like the non-confusing way to do it, with the redirection
inside the function.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


  reply	other threads:[~2008-11-13 14:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 21:20 Stephane Chazelas
2008-11-05 22:49 ` Phil Pennock
2008-11-06 14:38   ` Stephane Chazelas
2008-11-13 14:25 ` Stephane Chazelas
2008-11-13 14:42 ` [PATCH] " Stephane Chazelas
2008-11-13 14:52   ` Peter Stephenson [this message]
2008-11-13 15:03     ` Stephane Chazelas
2008-11-13 15:13       ` Stephane Chazelas
2008-11-13 15:27         ` Peter Stephenson
2008-11-13 14:55   ` Stephane Chazelas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811131452.mADEqx9i030855@news01.csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).