From: Stephane Chazelas <Stephane_Chazelas@yahoo.fr>
To: Peter Stephenson <pws@csr.com>
Cc: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: [PATCH] Re: f() { ...; } > file
Date: Thu, 13 Nov 2008 15:03:35 +0000 [thread overview]
Message-ID: <20081113150335.GD5114@sc.homeunix.net> (raw)
In-Reply-To: <200811131452.mADEqx9i030855@news01.csr.com>
On Thu, Nov 13, 2008 at 02:52:59PM +0000, Peter Stephenson wrote:
> Stephane Chazelas wrote:
> > The patch below seems to fix it. It just removes the special
> > case of f() { }. I don't why it was there in the first place.
> > rev 1.1 of parse.c already had it.
>
> That's because you've made all functions with braces parse as if they
> contain current shell structures; you'll see they're output with an
> unnecessary extra set of "{"s. This works because it just makes the
> code behave like the non-confusing way to do it, with the redirection
> inside the function.
[...]
Well, it depends how you regard the function syntax.
In the Bourne shell and its derivatives, defining a function
is really sticking foo() in front of a command. The "{" and "}"
are not part of the syntax of a function definition.
Note that POSIX has specified it with a restriction in that you
can only stick "foo()" in front of complex command, and bash is
the only shell to enforce that restriction.
bash allows:
foo() for i do echo "$i"; done
but not
foo() echo "$*"
contrary to all the other Bourne like shells which allow both.
Now, I agree that
$ /tmp/Z/bin/zsh -c 'f() { :; }; typeset -f'
f () {
{
:
}
}
is not ideal ;). Looks like the fix is not as easy as that.
--
Stéphane
next prev parent reply other threads:[~2008-11-13 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 21:20 Stephane Chazelas
2008-11-05 22:49 ` Phil Pennock
2008-11-06 14:38 ` Stephane Chazelas
2008-11-13 14:25 ` Stephane Chazelas
2008-11-13 14:42 ` [PATCH] " Stephane Chazelas
2008-11-13 14:52 ` Peter Stephenson
2008-11-13 15:03 ` Stephane Chazelas [this message]
2008-11-13 15:13 ` Stephane Chazelas
2008-11-13 15:27 ` Peter Stephenson
2008-11-13 14:55 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113150335.GD5114@sc.homeunix.net \
--to=stephane_chazelas@yahoo.fr \
--cc=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).